Create dedicated environment YML for Windows #4779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
michaelosthege
force-pushed
the
v3-ci-fixes
branch
from
e6e5d13 to
ba3fada
Compare
|
I can't really review this, @twiecki because I don't have access to a Windows box. And I like it that way! ;-) |
The install installation guide for Windows was recently updated after it was discovered that the combination of numba+scipy dependencies leads to the correct installation of BLAS dependencies.
michaelosthege
force-pushed
the
v3-ci-fixes
branch
from
ba3fada to
9c1bb54
Compare
|
Thanks @MarcoGorelli I put the h5py dependency back in. @rpgoldman I had hoped that this PR kinda reviews itself by fixing the CI pipeline that is broken on all other current v3 PRs. If we can merge it asap I'll rebase the other PRs to unblock the road to 3.11.3 @twiecki |
canyon289
approved these changes
Jun 19, 2021
| @@ -0,0 +1,26 @@ | |||
| name: pymc3-dev-py38 | |||
There was a problem hiding this comment.
Same comment as the other PR. Just add a docstring explaining the nuances of "what does windows do different"
There was a problem hiding this comment.
Deferred to #4786
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The install installation guide for Windows was recently updated after it was discovered that the combination of numba+scipy dependencies leads to the correct installation of BLAS dependencies.
This PR creates a conda
environment.ymlspecifically for Windows. That's because them2w64-toolchaindependency is Windows-only and conda does not yet support flags to make dependencies OS-specific.The GitHub Action for Windows was changed to use the new environment file.
Maybe this fixes the CI issues for the
v3branch.