Create dedicated environment YML for Windows & reenable tests #4785
Conversation
The install installation guide for Windows was recently updated after it was discovered that the combination of numba+scipy dependencies leads to the correct installation of BLAS dependencies.
| @@ -117,7 +127,7 @@ def main(conda_fname, pip_fname): | |||
| f"# This file is auto-generated by scripts/generate_pip_deps_from_conda.py, " | |||
| "do not modify.\n# See that file for comments about the need/usage of each dependency.\n\n" | |||
| ) | |||
| pip_content = header + "\n".join(pip_deps) + "\n" | |||
| pip_content = header + "\n".join(sorted(pip_deps)) + "\n" | |||
There was a problem hiding this comment.
Why does it have to be sorted?
There was a problem hiding this comment.
In the Windows env file I split the dependencies by absolutely necessary vs. dev/docs related. The function here then took them in the same order, but requirements-dev.txt is sorted by another step in the precommit..
| @@ -0,0 +1,37 @@ | |||
| name: pymc3-dev-py38 | |||
There was a problem hiding this comment.
Is there any particular reason the window dev environment needs to be different? If so add a comment up top so whoever reads this next is aware what those are.
I havet used windows in many years now so even I dont know, which is where the comment will help
There was a problem hiding this comment.
The m2w64-toolchain dependency is Windows-only, but conda doesn't support OS-conditional dependencies in these files..
I figured it was easier to maintain & diagnose two separate files than to find the set of dependencies that magically makes the conda dependency resolver find the correct result on all platforms.
There was a problem hiding this comment.
I would add this explanation to the file
There was a problem hiding this comment.
Deferred to #4786
This is based on a cherry-pick of the commit from #4779 which fixes the Windows step in the CI by using a more robust conda environment file.
I also re-enabled the Windows job in the CI, but did not yet add more test files.
This is the first step towards #4517