Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add model.logp_elemwiset #5245

Merged
merged 10 commits into from
Dec 13, 2021
Merged

Add model.logp_elemwiset #5245

merged 10 commits into from
Dec 13, 2021

Conversation

ricardoV94
Copy link
Member

Closes #5236
Closes #5230

ricardoV94
ricardoV94 commented Dec 7, 2021
View reviewed changes
pymc/model.py Outdated Show resolved Hide resolved
@ricardoV94 ricardoV94 force-pushed the logp_elemwiset branch 7 times, most recently from a3481b5 to 09fefa0 Compare December 8, 2021 10:22
@ricardoV94 ricardoV94 force-pushed the logp_elemwiset branch 4 times, most recently from 0682d72 to 80e5824 Compare December 8, 2021 11:12
@codecov
Copy link

codecov bot commented Dec 8, 2021 •
edited
Loading

Codecov Report

Merging #5245 (046fc7a) into main (7191e61) will increase coverage by 0.14%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5245      +/-   ##
==========================================
+ Coverage   78.98%   79.13%   +0.14%     
==========================================
  Files          88       88              
  Lines       14231    14337     +106     
==========================================
+ Hits        11240    11345     +105     
- Misses       2991     2992       +1
Impacted Files Coverage Δ
pymc/sampling_jax.py 0.00% <0.00%> (ø)
pymc/model.py 83.26% <85.41%> (-0.05%) ⬇️
pymc/distributions/logprob.py 96.49% <92.10%> (+1.44%) ⬆️
pymc/backends/arviz.py 89.51% <100.00%> (-0.05%) ⬇️
pymc/backends/report.py 89.51% <0.00%> (-2.10%) ⬇️
pymc/distributions/dist_math.py 86.78% <0.00%> (-0.92%) ⬇️
pymc/initial_point.py 100.00% <0.00%> (ø)
pymc/distributions/bound.py 100.00% <0.00%> (ø)
pymc/distributions/discrete.py 98.46% <0.00%> (+0.10%) ⬆️
... and 3 more

@ricardoV94 ricardoV94 mentioned this pull request Dec 8, 2021
Closed
@ricardoV94 ricardoV94 marked this pull request as ready for review December 8, 2021 12:25
@ricardoV94 ricardoV94 added this to the v4.0.0-beta1 (vNext) milestone Dec 8, 2021
OriolAbril
OriolAbril reviewed Dec 9, 2021
View reviewed changes
pymc/backends/arviz.py Show resolved Hide resolved
pymc/tests/test_idata_conversion.py Outdated Show resolved Hide resolved
@ricardoV94 ricardoV94 mentioned this pull request Dec 12, 2021
Open
@ricardoV94 ricardoV94 mentioned this pull request Dec 12, 2021
Open
OriolAbril
OriolAbril approved these changes Dec 12, 2021
View reviewed changes
Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only checked the arviz and test parts which look good, I can't really review the other files

@twiecki twiecki merged commit a50b386 into pymc-devs:main Dec 13, 2021
@ricardoV94 ricardoV94 mentioned this pull request Dec 13, 2021
Closed
@ricardoV94 ricardoV94 deleted the logp_elemwiset branch January 3, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twiecki twiecki twiecki approved these changes

@OriolAbril OriolAbril OriolAbril approved these changes

@kc611 kc611 Awaiting requested review from kc611

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0.0b1 (vNext)
3 participants
@ricardoV94 @twiecki @OriolAbril