Fix seeding issues in sequential sampling #5377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5377 +/- ##
==========================================
- Coverage 89.27% 89.27% -0.01%
==========================================
Files 74 74
Lines 13811 13815 +4
==========================================
+ Hits 12330 12333 +3
- Misses 1481 1482 +1
|
ricardoV94
force-pushed
the
seeding_issues
branch
from
f0be006
to
0401d8d
Compare
ricardoV94
force-pushed
the
seeding_issues
branch
from
0401d8d
to
0c774c0
Compare
ricardoV94
force-pushed
the
seeding_issues
branch
from
0c774c0
to
09c8330
Compare
…prepare_iter_sample` This reverts some changes in 47b61de which wrongly disabled global seeding in some sampling contexts that still depended on it.
ricardoV94
force-pushed
the
seeding_issues
branch
from
09c8330
to
0ebf04e
Compare
3 tasks
twiecki
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some seeding issues in sequential sampling and reveals others related to ADVI sampling (described in #5784)
Closes #5378