Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix seeding issues in sequential sampling #5377

Merged
merged 2 commits into from
May 19, 2022
Merged

Fix seeding issues in sequential sampling #5377

merged 2 commits into from
May 19, 2022

Commits on May 19, 2022

  1. Add explanation to test_sample_does_not_set_seed

    @ricardoV94
    ricardoV94 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    f446af0 View commit details
    Browse the repository at this point in the history

  2. Pass seed to find_map and set global seeds in _iter_sample and `_… 

    …prepare_iter_sample`

This reverts some changes in 47b61de which wrongly disabled global seeding in some sampling contexts that still depended on it.
    @ricardoV94
    ricardoV94 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    0ebf04e View commit details
    Browse the repository at this point in the history