Fix bug that does not correctly set the dtype of determinsitic variab… #6425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6425 +/- ##
===========================================
+ Coverage 78.24% 94.77% +16.52%
===========================================
Files 148 148
Lines 27731 27731
===========================================
+ Hits 21698 26281 +4583
+ Misses 6033 1450 -4583
|
ricardoV94
reviewed
Jan 2, 2023
ricardoV94
approved these changes
Jan 2, 2023
|
one of these test failures may be flaky, but the |
|
I'll take a look at the failing tests later today unless someone else beats me to it |
jessegrabowski
commented
Jan 12, 2023
pymc/tests/test_model.py
Outdated
| @@ -356,6 +356,9 @@ def test_missing_data(self): | |||
|
|
|||
| assert m["x2_missing"].type == gf._extra_vars_shared["x2_missing"].type | |||
|
|
|||
| # The dtype of the merged observed/missing deterministic should match the RV dtype | |||
| assert m.deterministics[0].type.dtype == str(X.dtype) | |||
There was a problem hiding this comment.
Sorry @michaelosthege, I've been busy with school stuff. My guess is that is line is what causes the test to fail?
…le after automatic imputation
…ng vector Co-authored-by: Ricardo Vieira <28983449+ricardoV94@users.noreply.github.com>
michaelosthege
force-pushed
the
missing_int_data
branch
from
b75946b to
a37ec86
Compare
michaelosthege
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Closes #6424 by setting the dtype of combined observed/interpolated deterministic generated by
model.make_obs_varto be the same as the underling RV being interpolated.Checklist
Major / Breaking Changes
New features
Bugfixes
Documentation
Maintenance