Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that does not correctly set the dtype of determinsitic variab… #6425

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Fix bug that does not correctly set the dtype of determinsitic variab… #6425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b509ed
Fix bug that does not correctly set the dtype of determinsitic variab…
jessegrabowski Jan 2, 2023
a37ec86
Change `at.zeros` to `at.empty` when creating combined observed/missi…
jessegrabowski Jan 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pymc/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1456,7 +1456,7 @@ def make_obs_var(

# Create deterministic that combines observed and missing
# Note: This can widely increase memory consumption during sampling for large datasets
rv_var = at.zeros(data.shape)
rv_var = at.empty(data.shape, dtype=observed_rv_var.type.dtype)
rv_var = at.set_subtensor(rv_var[mask.nonzero()], missing_rv_var)
rv_var = at.set_subtensor(rv_var[antimask_idx], observed_rv_var)
rv_var = Deterministic(name, rv_var, self, dims)
Expand Down
3 changes: 3 additions & 0 deletions pymc/tests/test_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,9 @@ def test_missing_data(self):

assert m["x2_missing"].type == gf._extra_vars_shared["x2_missing"].type

# The dtype of the merged observed/missing deterministic should match the RV dtype
assert m.deterministics[0].type.dtype == x2.type.dtype

pnt = m.initial_point(random_seed=None).copy()
del pnt["x2_missing"]

Expand Down