Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pylint and pre-commit autoupdate #1519

Merged
merged 3 commits into from
Apr 25, 2023
Merged

pylint and pre-commit autoupdate #1519

merged 3 commits into from
Apr 25, 2023

Conversation

jamesbraza
Copy link
Contributor

Modernizes pre-commit and pylint versions, implementing all suggested fixes.

@janiversen
Copy link
Collaborator

Looks good to me, will wait for green light, to make the real review.

Would be nice if this could be split in 2, one with the code changes (first) and one with the configuration changes (second), that makes it easier to bisect if we run into problems later.

@jamesbraza
Copy link
Contributor Author

Alright, got the green light 🟢

For stuff like this, I have seen it where old versions of tools have bugs that got fixed. If one is to break the PR into two pieces, one would have to temporarily add more disable comments, just to remove them in the next PR.

@janiversen janiversen merged commit 487d2dd into pymodbus-dev:dev Apr 25, 2023
@janiversen
Copy link
Collaborator

Good argument merged.

@jamesbraza jamesbraza deleted the tooling-update branch April 25, 2023 17:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants