32-bit Linux running on 64-bit ARM arch should have platform "linux_armv7l" #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no idea why the coverage dropped... |
…rmv7l". Currently on a 32-bit OS that runs on a 64-bit ARM CPU (ARM-v8, aarch64), _linux_platforms returns the incorrect string. This commit fixes this issue by following the solution similar to that of the x86_64/x86 pair.
xuhdev
requested review from
brettcannon,
pradyunsg and
chrahunt
and removed request for
brettcannon
brettcannon
approved these changes
Jan 24, 2020
brettcannon
requested changes
Jan 24, 2020
Co-Authored-By: Brett Cannon <54418+brettcannon@users.noreply.github.com>
Co-Authored-By: Brett Cannon <54418+brettcannon@users.noreply.github.com>
|
No idea what the lint error means.. |
|
@xuhdev you need to run black over your code to fix your formatting. |
xuhdev
force-pushed
the
arm
branch
5 times, most recently
from
18c0f14
to
2667118
Compare
xuhdev
added a commit
to xuhdev/pypa-packaging
that referenced
this pull request
Jan 28, 2020
Directly calling "pytest" sometimes breaks tests on "pypy", such as pypa#234. As explained from pypy website <https://docs.pytest.org/en/latest/usage.html>: > ["python -m pytest"] is almost equivalent to invoking the command line > script pytest [...] directly, except that calling via python will also > add the current directory to sys.path. Note that the pytest script is not directly invoked in tests for other Python interpreters.
xuhdev
added a commit
to xuhdev/pypa-packaging
that referenced
this pull request
Jan 28, 2020
Directly calling "pytest" sometimes breaks tests on "pypy", such as pypa#234. As explained from pypy website <https://docs.pytest.org/en/latest/usage.html>: > ["python -m pytest"] is almost equivalent to invoking the command line > script pytest [...] directly, except that calling via python will also > add the current directory to sys.path. Note that, unlike tests for pypy, the pytest script is not directly invoked in tests for other Python interpreters.
xuhdev
added a commit
to xuhdev/pypa-packaging
that referenced
this pull request
Jan 28, 2020
Directly calling "pytest" sometimes breaks tests on "pypy", such as pypa#234, because the actual current code is untested. As explained from pypy website <https://docs.pytest.org/en/latest/usage.html>: > ["python -m pytest"] is almost equivalent to invoking the command line > script pytest [...] directly, except that calling via python will also > add the current directory to sys.path. Note that, unlike tests for pypy, the pytest script is not directly invoked in tests for other Python interpreters.
|
@brettcannon All tests have passed now. Could you review again? Thanks! |
brettcannon
requested changes
Feb 1, 2020
Co-Authored-By: Brett Cannon <54418+brettcannon@users.noreply.github.com>
Co-Authored-By: Brett Cannon <54418+brettcannon@users.noreply.github.com>
|
Ping @brettcannon |
brettcannon
approved these changes
Feb 6, 2020
|
OK to have this merged w/o my review. |
xuhdev
added a commit
to IBM/MAX-Object-Detector
that referenced
this pull request
Feb 10, 2020
As pypa/packaging#234 has been merged.
This was referenced Feb 10, 2020
Closed
xuhdev
added a commit
to IBM/MAX-Object-Detector
that referenced
this pull request
Apr 30, 2020
The bug in pypa/packaging#234 is now in the current stable pip.
xuhdev
added a commit
to IBM/MAX-Object-Detector
that referenced
this pull request
Apr 30, 2020
The bug in pypa/packaging#234 is now in the current stable pip.
messense
reviewed
Oct 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on a 32-bit OS that runs on a 64-bit ARM CPU (ARM-v8,
aarch64),
_linux_platformsreturns the incorrect string. This commitfixes this issue by following the solution similar to that of the
x86_64/x86 pair.
Ported from pypa/pip#7352
cc @chrahunt @bdwyer2