Support 32-bit Linux running on 64-bit ARM arch. #7352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A 32-bit Linux running on 64-bit ARM arch should have platform "linux_armv7l".
bdwyer2
approved these changes
Nov 14, 2019
|
Can you provide any context for this change? As-is it is very hard to evaluate this. Also note #6908 - it may be better to submit this to pypa/packaging. |
|
@chrahunt I've updated the original comment to show more info. Thanks! |
chrahunt
removed
the
S: awaiting response
|
Thanks! Can you submit this to pypa/packaging instead? We're removing pep425tags soon and using packaging.tags. Our next release is January so this wouldn't get in before we make that change and we'd want to make sure the quality is up to those standards (e.g. tests). |
|
@chrahunt Thanks, I've created a PR at pypa/packaging#234 |
|
Closing in favor of pypa/packaging#234 |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A 32-bit Linux running on 64-bit ARM arch should have platform "linux_armv7l".
Currently on a 32-bit OS that runs on a 64-bit ARM CPU (ARM-v8, aarch64), pip installing a armv7l wheel gives the following error message:
This is caused by a misjudgment of the platform in pip: pip judges the system to be armv8/aarch64, but the system is actually armv7l, which is 32-bit. This PR fixes this issue by following the solution similar to that of the x86_64/x86 pair.