Shell auto completion should also auto complete short options

[segevfiner]

• Pip version: 9.0.1
• Python version: 2.7.12
• Operating system: Ubuntu 16.04

Description:

Pip's shell auto completion doesn't auto complete short options. The relevant code is:

pip/src/pip/_internal/__init__.py

Lines 130 to 131 in 729990c

	subcommands += [i.get_opt_string() for i in opts
	if i.help != optparse.SUPPRESS_HELP]

Which uses: cpython/Lib/optparse.py:752-756 which returns only the long option, if it's defined.

As a further limitation, which I'm not sure is triggered by Pip's auto completion, is that this will only autocomplete the first long option defined for an option that has multiple long options.

If it's acceptable, we can use the _short_opts and _long_opts attributes to calculate the completions so that we get all short and long options. What do you think?

What I've run:

➜ eval "$(pip completion --zsh)"

➜ pip install -<tab>
# You get:
➜ pip install --
# Since -- is unambiguous when no short options are completed.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.