Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auto completion of short options #4956

Merged
merged 2 commits into from
Mar 26, 2018
Merged

Add auto completion of short options #4956

merged 2 commits into from
Mar 26, 2018

Conversation

segevfiner
Copy link
Contributor

Fixes #4954

P.S. Pip's auto completion is still quite messy regardless, not completing file names (#4842), not recognizing (At least in Zsh) that it shouldn't add a space after = for a long option. So Pip's builtin auto completion is not really all that usable currently regardless.

@segevfiner segevfiner force-pushed the complete-short-opts branch from c97c899 to f029545 Compare January 5, 2018 12:22
@segevfiner segevfiner force-pushed the complete-short-opts branch from f029545 to bca2f4e Compare January 6, 2018 09:00
@pradyunsg
Copy link
Member

Could you add some tests for this?

@pradyunsg pradyunsg added type: enhancement Improvements to functionality C: autocomplete Autocompletion in shells (pip completion) labels Jan 24, 2018
@segevfiner
Copy link
Contributor Author

@pradyunsg Added tests

@pradyunsg pradyunsg mentioned this pull request Mar 1, 2018
Closed
@pradyunsg pradyunsg added this to the 10.0 milestone Mar 1, 2018
pfmoore
pfmoore approved these changes Mar 1, 2018
View reviewed changes
Copy link
Member

@pfmoore pfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use autocompletion myself, but a visual review of the code looks OK to me. I'll leave it to someone else to merge though.

@pfmoore
Copy link
Member

pfmoore commented Mar 26, 2018

@pradyunsg Are you OK to merge this?

@pradyunsg
Copy link
Member

Yep.

@pradyunsg pradyunsg mentioned this pull request Mar 26, 2018
Closed
@pfmoore pfmoore merged commit 3075034 into pypa:master Mar 26, 2018
@segevfiner segevfiner deleted the complete-short-opts branch November 4, 2018 19:00
@lock
Copy link

lock bot commented May 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 31, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pfmoore pfmoore pfmoore approved these changes

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation C: autocomplete Autocompletion in shells (pip completion) type: enhancement Improvements to functionality
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.

Shell auto completion should also auto complete short options
3 participants
@segevfiner @pradyunsg @pfmoore