Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate message_about_scripts_not_on_PATH to use pathlib #11903

Closed
wants to merge 8 commits into from

Conversation

pradyunsg
Copy link
Member

I've split this from #11719, since it's a separate change.

@github-actions github-actions bot added the needs rebase or merge PR has conflicts with current master label Mar 27, 2023
@uranusjr
Copy link
Member

This actually changes the semantic a bit since resolve resolves symlinks while normpath does not. But arguably the new behaviour is more correct anyway.

@lorddavidiii
Copy link
Contributor

I think so also, that this is the more correct anyway. So I rebased this branch, but I am not allowed to push this, should I open an new PR?

@uranusjr
Copy link
Member

A new PR is easiest.

@lorddavidiii
Copy link
Contributor

ok, open a new one #11953, so this can be closed.

@pradyunsg pradyunsg closed this Apr 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs rebase or merge PR has conflicts with current master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants