message_about_scripts_not_on_PATH: use pathlib for path normalization and resolve symlinks #11953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d script_name directly
…dir and script_name Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
lorddavidiii
force-pushed
the
norm-path-with-pathlib
branch
from
959c781
to
cc112bf
Compare
uranusjr
reviewed
Apr 12, 2023
news/11953.feature.rst
Outdated
| @@ -0,0 +1 @@ | |||
| Migrate message_about_scripts_not_on_PATH to use pathlib | |||
There was a problem hiding this comment.
This should mention the slight behavioural change mentioned in the other PR.
There was a problem hiding this comment.
ok, I change this now
lorddavidiii
changed the title
|
The failing CI job looks unrelated to this PR |
|
The new message is still not good enough to me. pip users would not have a clue what |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the rebased version of #11903