Release/25.3 #13631
Release/25.3 #13631
Conversation
|
Some of the author additions look odd, I will take a look at the process that adds them before merging. |
notatallshaw
force-pushed
the
release/25.3
branch
from
4476944 to
eaec979
Compare
notatallshaw
force-pushed
the
release/25.3
branch
from
eaec979 to
6bd493e
Compare
| - Remove support for the legacy ``setup.py develop`` editable method in setuptools | ||
| editable installs; setuptools >= 64 is now required. (`#11457 <https://github.com/pypa/pip/issues/11457>`_) |
There was a problem hiding this comment.
Hmm, does pip raise a friendly error on pip install -e project --no-build-isolation when setuptools<64 is installed? Not sure how common this would be, but it could trip some people up @sbidoul.
There was a problem hiding this comment.
That can be a possible future improvement, even maybe for a 25.3.1.
But detecting the version of the selected setuptools sounds fraught with edge cases, I wouldn't accept a PR for that today.
There was a problem hiding this comment.
❯ pip install -e "pip-test-package @ git+https://github.com/pypa/pip-test-package" --no-build-isolation
Obtaining pip-test-package from git+https://github.com/pypa/pip-test-package
Cloning https://github.com/pypa/pip-test-package to ./.venv/src/pip-test-package
Running command git clone --filter=blob:none --quiet https://github.com/pypa/pip-test-package /tmp/brol/.venv/src/pip-test-package
Resolved https://github.com/pypa/pip-test-package to commit 96d6d72ac54132aecbdd5adac88bc8d1f8fb986b
Checking if build backend supports build_editable ... done
ERROR: Project pip-test-package from git+https://github.com/pypa/pip-test-package uses a build backend that is missing the 'build_editable' hook, so it cannot be installed in editable mode. Consider using a build backend that supports PEP 660.
That sounds reasonable. To do more we'd need to reintroduce setuptools-specific code which I'm not keen to do. I'd rather address that via documentation and communication.
There was a problem hiding this comment.
Hmm, if we don't want to add setuptools specific code, then perhaps adding a "consider upgrading your locally installed build backend" when --no-build-isolation hint may be better. That's obviously out of scope for the pip 25.3 release cycle though.
|
Mistakes were made 🙁, there is no release, I'm following up shortly with a fix. |
3 participants
Toward #13522
I intend to merge this PR around 19:00 Americas/New_York.