-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Release/25.3 #13631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/25.3 #13631
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, does pip raise a friendly error on
pip install -e project --no-build-isolationwhensetuptools<64is installed? Not sure how common this would be, but it could trip some people up @sbidoul.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That can be a possible future improvement, even maybe for a 25.3.1.
But detecting the version of the selected setuptools sounds fraught with edge cases, I wouldn't accept a PR for that today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds reasonable. To do more we'd need to reintroduce setuptools-specific code which I'm not keen to do. I'd rather address that via documentation and communication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, if we don't want to add setuptools specific code, then perhaps adding a "consider upgrading your locally installed build backend" when
--no-build-isolationhint may be better. That's obviously out of scope for the pip 25.3 release cycle though.