fix PEP 518 support when pip is installed in the user site

[benoit-pierre]

Do not use the build environment isolation during the build dependencies installation.

Note: included are the changes originally proposed in #5189 as well as an additional patch fixing the virtualenvs used by the testsuite so user site packages are correctly handled.

Fix #5224.

[pv]

I tested this indeed fixes the failure I reported #5224.

[pv]

Looking at this, I was at first worried the build isolation would be important to have for the dependencies, but IIUC each build dep anyway gets its own isolated environment if it has a pyproject.toml, so the logic is OK as far as I see.

[pradyunsg]

It'd be nicer if you reopen the earlier PR and separate these changes from those. I was about to go to merge those but saw you'd closed that PR. :/

[pradyunsg]

I feel it'd be cleaner to just move "installation of build requirements" to become a method of BuildEnvironment (and update NoOpBuildEnvironement) accordingly.

[benoit-pierre]

I'd rather do those cleanups in a dedicated PR. I planned to do one to remove the BuildEnvironment.no_clean code too, it's not used.

I can move the first 2 commits in a dedicated PR.

[pradyunsg]

Thanks for that. :)

…

On Sun, 15 Apr 2018, 14:14 Benoit Pierre, ***@***.***> wrote: I'd rather do those cleanups in a dedicated PR. I planned to do one to remove the BuildEnvironment.no_clean code too, it's not used. I can move the first 2 commits in a dedicated PR. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5227 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADH7SaS3UxWkgqXh7dDhb0JmSr8-kS-Nks5towhhgaJpZM4TVQZS> .

[benoit-pierre]

OK, so #5235 should be merged first.

[pfmoore]

@pradyunsg:

I feel it'd be cleaner to just move "installation of build requirements" to become a method of BuildEnvironment (and update NoOpBuildEnvironement) accordingly.

Do you still wish this to be done? Could this be deferred to a tidy-up PR once 10.0.1 is released? I'm reluctant to delay 10.0.1 over a cosmetic issue in the code.

Happy to let this go through as is for now.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.