Use a helper to ensure tox always runs a known-good pip version #5770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
added
skip news
pradyunsg
commented
Sep 7, 2018
| install_command = python -m pip install {opts} {packages} | ||
| usedevelop = True | ||
| commands = | ||
| {[shorthands]pip} install -e {toxinidir} |
There was a problem hiding this comment.
tox runs freeze after installing develop if usedevelop = True.
This is why this is a separate line in commands.
There was a problem hiding this comment.
We could be "smart" in the wrapper script and not overwrite if we're doing a freeze but this is a bit more robust in case pip freeze is what breaks.
Plus we can then just remove multiple skip_install = True lines and add the above installation line to simply install when needed, instead of vice versa.
pradyunsg
changed the title
pradyunsg
changed the title
pradyunsg
force-pushed
the
tests/preserve-tox-pip
branch
from
5de6216
to
e54da08
Compare
|
@pfmoore Could you take this for a spin on Windows, and see how this fits with your workflow? |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #4657
Adds a helper that backs up a known good pip on the first invocation in a tox venv and replaces the installed version with that on every subsequent run. Arguably there's scope for improvement here by not replacing unless it might be broken but I'd consider that an optimization.
This change as it stands, means breaking pip horribly does not result in tox environments not being functional, which is an improvement.