tox: fix environment setup #5843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure a stable version of pip is used for installing dependencies, and not the version about to be tested.
benoit-pierre
force-pushed
the
fix_tox.ini_install_command
branch
from
68f3221
to
c9e47c9
Compare
|
Updated to use a recent stable version of pip instead of the version available in the virtualenv: the later can be pretty old (no support for |
pradyunsg
added
C: automation
|
It's definitely simpler. :) I'm gonna go ahead and merge this, since this is a process improvement that I'd really prefer to not hold off on any longer. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the virtualenv's pip for installing dependencies, not the code that is about to be tested. Another stab at #4657 and a simpler (IMHO) alternative to and closes #5770.