Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete type annotations in "pip._internal.wheel_builder" #8337

Merged
merged 3 commits into from
Jun 27, 2020
Merged

Complete type annotations in "pip._internal.wheel_builder" #8337

merged 3 commits into from
Jun 27, 2020

Conversation

deveshks
Copy link
Contributor

@deveshks deveshks commented May 27, 2020 •
edited
Loading

Towards #4748

Added type annotations to pip._internal.wheel_builder.

cc @pradyunsg

@deveshks deveshks force-pushed the mypy/pip/internal branch 3 times, most recently from bbb67bb to 4fa12f2 Compare June 1, 2020 18:41
@deveshks
Copy link
Contributor Author

deveshks commented Jun 6, 2020

May I get this reviewed?

@pradyunsg
Copy link
Member

Could you split this out into 3 separate PRs? I think we need to iterate on configuration and cache, but wheel_builder LGTM.

@deveshks
Copy link
Contributor Author

Could you split this out into 3 separate PRs? I think we need to iterate on configuration and cache, but wheel_builder LGTM.

Okay I can make this PR just about wheel_builder, and move configuration and cache into their own PRs.

@deveshks deveshks changed the title Complete type annotations in "pip._internal.{cache, configuration, wheel_builder}" Complete type annotations in "pip._internal.wheel_builder" Jun 25, 2020
@deveshks
Copy link
Contributor Author

Okay I can make this PR just about wheel_builder, and move configuration and cache into their own PRs.

This PR just contains the wheel_builder now, and can be approved/merged.

@deveshks deveshks requested a review from sbidoul June 25, 2020 17:58
sbidoul
sbidoul approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@deveshks
Copy link
Contributor Author

Thanks!

Thanks for the approval @sbidoul . May I get it merged as well?

Also I hope that it's not too much to ask, but since you have reviewed almost all my type annotation PRs, if it's not too much to ask, could you take a look at #8365 and #8322 as well?

@sbidoul sbidoul merged commit 69a811c into pypa:master Jun 27, 2020
@deveshks deveshks deleted the mypy/pip/internal branch June 27, 2020 09:05
@deveshks
Copy link
Contributor Author

deveshks commented Jul 9, 2020

Could you split this out into 3 separate PRs? I think we need to iterate on configuration and cache, but wheel_builder LGTM.

Hi @pradyunsg ,

As per your suggestion, I have created #8565 and #8566 for adding type annotations to cache and configuration respectively. Please take a look.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sbidoul sbidoul sbidoul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deveshks @pradyunsg @sbidoul