Complete type annotations in "pip._internal.operations.{check,freeze}" and "pip._internal.utils.subprocess" #8322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
McSinyx
reviewed
May 26, 2020
pradyunsg
reviewed
May 26, 2020
deveshks
force-pushed
the
mypy-internal-ops
branch
2 times, most recently
from
748a098
to
28cd824
Compare
|
The review comments have been addressed, and this should be good for further reviews and/or approval/merge. |
deveshks
force-pushed
the
mypy-internal-ops
branch
from
a847dda
to
161ce80
Compare
|
Hi @pradyunsg I believe this PR is ready for final set of reviews and then an approval/merge. |
deveshks
force-pushed
the
mypy-internal-ops
branch
from
161ce80
to
36af6f6
Compare
sbidoul
reviewed
Jun 26, 2020
deveshks
force-pushed
the
mypy-internal-ops
branch
from
4d55a57
to
ecbe065
Compare
That's absolutely fine. Please feel free to review |
sbidoul
reviewed
Jun 27, 2020
deveshks
force-pushed
the
mypy-internal-ops
branch
from
ac196cd
to
1da909e
Compare
sbidoul
reviewed
Jun 27, 2020
deveshks
force-pushed
the
mypy-internal-ops
branch
from
1da909e
to
8fc3fee
Compare
sbidoul
approved these changes
Jun 27, 2020
|
Thanks for the approval @sbidoul . May I get it merged as well? |
deveshks
force-pushed
the
mypy-internal-ops
branch
from
8fc3fee
to
245bcd0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #4748
Added type annotations to
pip._internal.operations.check,pip._internal.operations.freezeandpip._internal.utils.subprocess