-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Describe --upgrade-strategy and direct requirements explicitly #8739
Conversation
@uranusjr Here's a low-effort attempt to render our convo as a PR. I settled on "direct/indirect requirements", with some inline explanation, as those seemed like existing terms of art. |
|
||
This will only update ``SomePackage`` as it is a direct requirement. Any | ||
of its dependencies (indirect requirements) will be affected by the | ||
``--upgrade-strategy`` command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indirect requirements can still be upgraded here if a later version of SomePackage
needs them upgraded. Say
SomePackage==1.0
needsDepPackage==1.0
SomePackage==2.0
needsDepPackage==2.0
With SomePackage==1.0
and DepPackage==1.0
initially installed, pip install --upgrade SomePackage
will still upgrade DepPackage
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IOW, only SomePackage
is guarenteed to be upgraded. Its dependencies are upgraded only if needed.
Hello! I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the |
Closing as this is significantly out of date, and has merge conflicts. Please do feel free to resubmit an updated PR for this! ^>^ Thanks @EricCousineau-TRI for the PR! :) |
Sorry! Saw something shiny a few months back 😬 Filed #9692 as redux. |
Add a brief example
Resolves #8726