Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mailmap: Clean up my Git entries #9277

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Dec 14, 2020

Before

$ git shortlog -se | grep -i hugovk
    30	Hugo <hugovk@users.noreply.github.com>
    14	Hugo van Kemenade <hugovk@users.noreply.github.com>
     4	hugovk <hugovk@users.noreply.github.com>

After

$ git shortlog -se | grep -i hugovk
    49	Hugo van Kemenade <hugovk@users.noreply.github.com>

@hugovk
Copy link
Contributor Author

hugovk commented Dec 14, 2020

news-file/pr — Missing either a news entry or a trivial file/label.

Looks like it didn't find the file made with touch news/$(uuidgen).trivial.rst (via https://pip.pypa.io/en/latest/development/contributing/#choosing-the-type-of-news-entry)

@pradyunsg
Copy link
Member

Looks like it didn't find the file made with touch news/$(uuidgen).trivial.rst (via pip.pypa.io/en/latest/development/contributing/#choosing-the-type-of-news-entry)

OH boi.

Would it be OK if I use this PR as a testing ground for figuring out what's up with the bot?

@hugovk
Copy link
Contributor Author

hugovk commented Dec 14, 2020

Sure thing! Do whatever you like, and let me know if I can help!

@hugovk
Copy link
Contributor Author

hugovk commented Dec 14, 2020

The bot was happy with news/kjvxeqa8s2bhzz6vtccxp6cj.trivial.rst in #9275.

@hugovk
Copy link
Contributor Author

hugovk commented Dec 14, 2020

Could it be that I didn't include the file in the first push, then added it and force-pushed?

@pradyunsg pradyunsg added skip news Does not need a NEWS file entry (eg: trivial changes) and removed skip news Does not need a NEWS file entry (eg: trivial changes) labels Dec 14, 2020
@pradyunsg
Copy link
Member

2020-12-14T18:14:57.894861+00:00 app[web.1]: 2020-12-14T18:14:57+0000 [browntruck.hooks.news#info] 9277: news file was not updated

No -- I think it's something weird.

https://github.com/pypa/browntruck/blob/twisted/browntruck/hooks/news.py#L109

We need better logging tho.

@hugovk hugovk mentioned this pull request May 20, 2021
@hugovk
Copy link
Contributor Author

hugovk commented Jun 1, 2021

As discovered in #10001 (comment), adding content to the trivial file unblocks the news bot. 👍

@uranusjr uranusjr merged commit 57be6a7 into pypa:main Jun 1, 2021
@hugovk hugovk deleted the hugovk-update-mailmap branch June 1, 2021 18:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants