Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "legacy-resolver" option, part 1 #9631

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove "legacy-resolver" option, part 1 #9631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
305e6e7
Remove legacy resolver from tests
MrMino Feb 20, 2021
bb8b860
Remove "legacy-resolver" option
MrMino Feb 20, 2021
1c985e7
Add a news entry
MrMino Feb 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions news/9631.removal.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Usage of the old resolver via --use-deprecated=legacy-resolver is no longer
available.
1 change: 0 additions & 1 deletion src/pip/_internal/cli/cmdoptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -965,7 +965,6 @@ def check_list_path_option(options: Values) -> None:
action="append",
default=[],
choices=[
"legacy-resolver",
"out-of-tree-build",
"backtrack-on-build-failures",
"html5lib",
Expand Down
5 changes: 1 addition & 4 deletions tests/functional/test_install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,17 +495,14 @@ def test_vcs_url_urlquote_normalization(
)


@pytest.mark.parametrize("resolver", ["", "--use-deprecated=legacy-resolver"])
@pytest.mark.usefixtures("with_wheel")
def test_basic_install_from_local_directory(
script: PipTestEnvironment, data: TestData, resolver: str
script: PipTestEnvironment, data: TestData
) -> None:
"""
Test installing from a local directory.
"""
args = ["install"]
if resolver:
args.append(resolver)
to_install = data.packages.joinpath("FSPkg")
args.append(to_install)
result = script.pip(*args)
Expand Down