Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "legacy-resolver" option, part 1 #9631

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove "legacy-resolver" option, part 1 #9631

wants to merge 3 commits into from

Conversation

MrMino
Copy link
Contributor

@MrMino MrMino commented Feb 20, 2021 •
edited
Loading

This is a subset of #9695

This is the first step on the road to fully remove the legacy resolver. The aims of this PR are strictly as follows:

  • Prohibit usage of --use-deprecated=legacy-resolver
  • Make sure the tests don't fail.

Edit: thanks to #9739 the yaml tests issue has been eliminated.

@MrMino MrMino marked this pull request as ready for review February 21, 2021 16:39
@MrMino MrMino mentioned this pull request Feb 21, 2021
Closed
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Feb 23, 2021
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Feb 24, 2021
@uranusjr uranusjr mentioned this pull request Mar 2, 2021
Merged
@MrMino MrMino force-pushed the remove_legacy_resolver branch from c48a7f7 to 708e39b Compare March 6, 2021 21:28
@MrMino MrMino mentioned this pull request Mar 6, 2021
Closed
@MrMino MrMino changed the title Remove "legacy-resolver" option Remove "legacy-resolver" option, part 1 Mar 6, 2021
@pradyunsg pradyunsg added this to the Drop the legacy resolver milestone Mar 18, 2021
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Mar 28, 2021
@MrMino MrMino force-pushed the remove_legacy_resolver branch from 708e39b to 1a22c40 Compare March 28, 2021 13:32
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Mar 28, 2021
@MrMino MrMino mentioned this pull request Mar 28, 2021
Merged
pradyunsg
pradyunsg requested changes Mar 28, 2021
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My two cents here: The change looks good, but let's not merge this for 21.1.

I'm not sure any one of us will have the bandwidth to deal with the pitchforks that come in when we'll release this.

@pfmoore
Copy link
Member

pfmoore commented Mar 28, 2021

That sounds like a good call.

@MrMino
Copy link
Contributor Author

MrMino commented Mar 28, 2021

Yup, sounds sensible.

@dolfinus dolfinus mentioned this pull request Apr 27, 2021
Closed
@github-actions github-actions bot added the needs rebase or merge PR has conflicts with current master label Aug 20, 2021
@balloob balloob mentioned this pull request Jan 12, 2022
Closed
1 task
@MrMino MrMino force-pushed the remove_legacy_resolver branch from 1a22c40 to 1c985e7 Compare March 3, 2022 22:15
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Mar 3, 2022
@github-actions github-actions bot added the needs rebase or merge PR has conflicts with current master label Apr 9, 2022
@chrysle
Copy link
Contributor

chrysle commented May 4, 2024

What's the state here?

@pradyunsg
Copy link
Member

Same as #10946 (comment) -- the new resolver still does not have feature parity on a couple of workflows and we should cover those before we remove the legacy resolver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradyunsg pradyunsg pradyunsg requested changes

@pfmoore pfmoore pfmoore approved these changes

Assignees
No one assigned
Labels
needs rebase or merge PR has conflicts with current master
Projects
None yet
Milestone
Drop the legacy resolver
Development

Successfully merging this pull request may close these issues.
6 participants
@MrMino @BrownTruck @pfmoore @chrysle @pradyunsg @pypa-bot