Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipenv requirements does not include markers #5092

Closed
thomasf opened this issue May 1, 2022 · 6 comments
Closed

pipenv requirements does not include markers #5092

thomasf opened this issue May 1, 2022 · 6 comments
Assignees
@ImreC
Labels
Type: Bug 🐛 This issue is a bug.

Comments

@thomasf
Copy link

thomasf commented May 1, 2022 •
edited
Loading

I just tried to use pipenv reqirements instead of pipenv lock --requirements but it lacks markers so windows only dependencies from my lock file makes pip install -r ... fail.

example transitive dependency form lock file that at some point was locked on a windows machine:

        "twisted-iocpsupport": {
            "hashes": [
                "sha256:306becd6e22ab6e8e4f36b6bdafd9c92e867c98a5ce517b27fdd27760ee7ae41",
                "sha256:3c61742cb0bc6c1ac117a7e5f422c129832f0c295af49e01d8a6066df8cfc04d",
                "sha256:72068b206ee809c9c596b57b5287259ea41ddb4774d86725b19f35bf56aa32a9",
                "sha256:7d972cfa8439bdcb35a7be78b7ef86d73b34b808c74be56dfa785c8a93b851bf",
                "sha256:81b3abe3527b367da0220482820cb12a16c661672b7bcfcde328902890d63323",
                "sha256:851b3735ca7e8102e661872390e3bce88f8901bece95c25a0c8bb9ecb8a23d32",
                "sha256:985c06a33f5c0dae92c71a036d1ea63872ee86a21dd9b01e1f287486f15524b4",
                "sha256:9dbb8823b49f06d4de52721b47de4d3b3026064ef4788ce62b1a21c57c3fff6f",
                "sha256:b435857b9efcbfc12f8c326ef0383f26416272260455bbca2cd8d8eca470c546",
                "sha256:b76b4eed9b27fd63ddb0877efdd2d15835fdcb6baa745cb85b66e5d016ac2878",
                "sha256:b9fed67cf0f951573f06d560ac2f10f2a4bbdc6697770113a2fc396ea2cb2565",
                "sha256:bf4133139d77fc706d8f572e6b7d82871d82ec7ef25d685c2351bdacfb701415"
            ],
            "markers": "platform_system == 'Windows'",
            "version": "==1.0.2"
        },

Running pipenv lock --requirements --keep-outdated (on linux) results in:

twisted-iocpsupport==1.0.2; platform_system == 'Windows'

Running pipenv requirements (on linux) has no marker so the requirements file fails to install on linux.

twisted-iocpsupport==1.0.2

pipenv, version 2022.4.30
@matteius matteius changed the title pipenv requiremetns does not include markers pipenv requirements does not include markers May 2, 2022
@MrBones757
Copy link

We are also having this issue, and have reverted back to the lock mechanism.

@fridex
Copy link
Contributor

fridex commented May 3, 2022 •
edited
Loading

It looks like micropipenv requirements provides expected output.

@ImreC
Copy link
Contributor

ImreC commented May 20, 2022

@matteius shall I create a PR for this over the weekend?

@matteius
Copy link
Member

@ImreC That would be awesome 😎

@ImreC
Copy link
Contributor

ImreC commented May 23, 2022

Ok, forgot to do this. Will pick it up end of this week.

@matteius matteius added the Type: Bug 🐛 This issue is a bug. label May 26, 2022
@ImreC
Copy link
Contributor

ImreC commented May 30, 2022

PR open #5114

oz123 pushed a commit that referenced this issue Jun 25, 2022
@ImreC
Include markers issue #5092 (#5114)
37b1fb4 
* Include markers

* Change to marker flag and include test

* Flip markers flag to exclude by default

* Docs and newsfile

* Let default dependencies update dev dependencies
@oz123 oz123 closed this as completed Jun 25, 2022
cakekoa added a commit to guardicore/monkey that referenced this issue Feb 27, 2023
@cakekoa
Project: Use requirements file to install AppImage deps
27b0a1a 
Switch from using `pipenv sync --system` to using the requirements file
generated from `pipenv requirements`.

The `pipenv sync --system` command (added in #1993)  does not work in
newer versions of pipenv. It uses the python version of the system
rather than the one specified by the --python flag.

The `pipenv requirements` command has been added that only pulls from
the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed
to only dump out requirements for the appropriate system
(see pypa/pipenv#5092).
cakekoa added a commit to guardicore/monkey that referenced this issue Feb 27, 2023
@cakekoa
Project: Use requirements file to install AppImage deps
3c75397 
Switch from using `pipenv sync --system` to using the requirements file
generated from `pipenv requirements`.

The `pipenv sync --system` command (added in #1993)  does not work in
newer versions of pipenv. It uses the python version of the system
rather than the one specified by the --python flag.

The `pipenv requirements` command has been added that only pulls from
the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed
to only dump out requirements for the appropriate system
(see pypa/pipenv#5092).
cakekoa added a commit to guardicore/monkey that referenced this issue Feb 27, 2023
@cakekoa
Project: Use requirements file to install AppImage deps
c75bacc 
Switch from using `pipenv sync --system` to using the requirements file
generated from `pipenv requirements`.

The `pipenv sync --system` command (added in #1993)  does not work in
newer versions of pipenv. It uses the python version of the system
rather than the one specified by the --python flag.

The `pipenv requirements` command has been added that only pulls from
the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed
to only dump out requirements for the appropriate system
(see pypa/pipenv#5092).
mssalvatore pushed a commit to guardicore/monkey that referenced this issue Feb 27, 2023
@cakekoa @mssalvatore
Project: Use requirements file to install AppImage deps
81450cc 
Switch from using `pipenv sync --system` to using the requirements file
generated from `pipenv requirements`.

The `pipenv sync --system` command (added in #1993)  does not work in
newer versions of pipenv. It uses the python version of the system
rather than the one specified by the --python flag.

The `pipenv requirements` command has been added that only pulls from
the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed
to only dump out requirements for the appropriate system
(see pypa/pipenv#5092).
mssalvatore pushed a commit to guardicore/monkey that referenced this issue Feb 28, 2023
@cakekoa @mssalvatore
Project: Use requirements file to install AppImage deps
f90277b 
Switch from using `pipenv sync --system` to using the requirements file
generated from `pipenv requirements`.

The `pipenv sync --system` command (added in #1993)  does not work in
newer versions of pipenv. It uses the python version of the system
rather than the one specified by the --python flag.

The `pipenv requirements` command has been added that only pulls from
the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed
to only dump out requirements for the appropriate system
(see pypa/pipenv#5092).
mssalvatore pushed a commit to guardicore/monkey that referenced this issue Mar 1, 2023
@cakekoa @mssalvatore
Project: Use requirements file to install AppImage deps
aa8a0c6 
Switch from using `pipenv sync --system` to using the requirements file
generated from `pipenv requirements`.

The `pipenv sync --system` command (added in #1993)  does not work in
newer versions of pipenv. It uses the python version of the system
rather than the one specified by the --python flag.

The `pipenv requirements` command has been added that only pulls from
the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed
to only dump out requirements for the appropriate system
(see pypa/pipenv#5092).
mssalvatore pushed a commit to guardicore/monkey that referenced this issue Mar 1, 2023
@cakekoa @mssalvatore
Project: Use requirements file to install AppImage deps
65a3332 
Switch from using `pipenv sync --system` to using the requirements file
generated from `pipenv requirements`.

The `pipenv sync --system` command (added in #1993)  does not work in
newer versions of pipenv. It uses the python version of the system
rather than the one specified by the --python flag.

The `pipenv requirements` command has been added that only pulls from
the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed
to only dump out requirements for the appropriate system
(see pypa/pipenv#5092).
mssalvatore pushed a commit to guardicore/monkey that referenced this issue Mar 1, 2023
@cakekoa @mssalvatore
Project: Use requirements file to install AppImage deps
54fd1bd 
Switch from using `pipenv sync --system` to using the requirements file
generated from `pipenv requirements`.

The `pipenv sync --system` command (added in #1993)  does not work in
newer versions of pipenv. It uses the python version of the system
rather than the one specified by the --python flag.

The `pipenv requirements` command has been added that only pulls from
the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed
to only dump out requirements for the appropriate system
(see pypa/pipenv#5092).
mssalvatore pushed a commit to guardicore/monkey that referenced this issue Mar 1, 2023
@cakekoa @mssalvatore
Project: Use requirements file to install AppImage deps
fc095c1 
Switch from using `pipenv sync --system` to using the requirements file
generated from `pipenv requirements`.

The `pipenv sync --system` command (added in #1993)  does not work in
newer versions of pipenv. It uses the python version of the system
rather than the one specified by the --python flag.

The `pipenv requirements` command has been added that only pulls from
the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed
to only dump out requirements for the appropriate system
(see pypa/pipenv#5092).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ImreC ImreC

Labels
Type: Bug 🐛 This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@thomasf @matteius @fridex @oz123 @ImreC @MrBones757