Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appimage Island build fails #1993

Closed
1 task
VakarisZ opened this issue Jun 8, 2022 · 0 comments · Fixed by #2007
Closed
1 task

Appimage Island build fails #1993

VakarisZ opened this issue Jun 8, 2022 · 0 comments · Fixed by #2007
Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. sp/3

Comments

@VakarisZ
Copy link
Contributor

VakarisZ commented Jun 8, 2022 •
edited by mssalvatore
Loading

Describe the bug

We get an error building the appimage:

Collecting pytz==2022.1
  Using cached pytz-2022.1-py2.py3-none-any.whl (503 kB)
ERROR: Could not find a version that satisfies the requirement pywin32==304 (from versions: none)
ERROR: No matching distribution found for pywin32==304
WARNING: There was an error checking the latest version of pip.
Fix the errors above and rerun the script
Build step 'Execute shell' marked build as failure

This error appears because when building the AppImage we first create a requirements.txt file. This file is created disregarding the the system markers.

To Reproduce

Steps to reproduce the behavior:

  1. Build appimage with current island pipfiles

Expected behavior

Create a virtual environment in the appimage and do pipenv sync in there instead of creating the requirements file.

Machine version (please complete the following information):

  • OS: Linux

Tasks

  • Create a virtualenv within the appimage and run from there (0.75) @mssalvatore
@VakarisZ VakarisZ added the Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. label Jun 8, 2022
mssalvatore added a commit that referenced this issue Jun 9, 2022
@mssalvatore
Build: Use pipenv sync --system instead of requirements.txt
b8a5245 
When pipenv dumps the lock file to a requirements.txt, it does not
include the `sys_platform` directive. This causes pip to attempt to
install win32 packages, which fails. By using `pypenv sync --system`
instead, only packages applicable to Linux are installed.

Fixes #1993
@mssalvatore mssalvatore mentioned this issue Jun 9, 2022
Merged
8 tasks
cakekoa added a commit that referenced this issue Feb 27, 2023
@cakekoa
Project: Use requirements file to install AppImage deps
27b0a1a 
Switch from using `pipenv sync --system` to using the requirements file
generated from `pipenv requirements`.

The `pipenv sync --system` command (added in #1993)  does not work in
newer versions of pipenv. It uses the python version of the system
rather than the one specified by the --python flag.

The `pipenv requirements` command has been added that only pulls from
the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed
to only dump out requirements for the appropriate system
(see pypa/pipenv#5092).
cakekoa added a commit that referenced this issue Feb 27, 2023
@cakekoa
Project: Use requirements file to install AppImage deps
3c75397 
Switch from using `pipenv sync --system` to using the requirements file
generated from `pipenv requirements`.

The `pipenv sync --system` command (added in #1993)  does not work in
newer versions of pipenv. It uses the python version of the system
rather than the one specified by the --python flag.

The `pipenv requirements` command has been added that only pulls from
the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed
to only dump out requirements for the appropriate system
(see pypa/pipenv#5092).
cakekoa added a commit that referenced this issue Feb 27, 2023
@cakekoa
Project: Use requirements file to install AppImage deps
c75bacc 
Switch from using `pipenv sync --system` to using the requirements file
generated from `pipenv requirements`.

The `pipenv sync --system` command (added in #1993)  does not work in
newer versions of pipenv. It uses the python version of the system
rather than the one specified by the --python flag.

The `pipenv requirements` command has been added that only pulls from
the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed
to only dump out requirements for the appropriate system
(see pypa/pipenv#5092).
mssalvatore pushed a commit that referenced this issue Feb 27, 2023
@cakekoa @mssalvatore
Project: Use requirements file to install AppImage deps
81450cc 
Switch from using `pipenv sync --system` to using the requirements file
generated from `pipenv requirements`.

The `pipenv sync --system` command (added in #1993)  does not work in
newer versions of pipenv. It uses the python version of the system
rather than the one specified by the --python flag.

The `pipenv requirements` command has been added that only pulls from
the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed
to only dump out requirements for the appropriate system
(see pypa/pipenv#5092).
mssalvatore pushed a commit that referenced this issue Feb 28, 2023
@cakekoa @mssalvatore
Project: Use requirements file to install AppImage deps
f90277b 
Switch from using `pipenv sync --system` to using the requirements file
generated from `pipenv requirements`.

The `pipenv sync --system` command (added in #1993)  does not work in
newer versions of pipenv. It uses the python version of the system
rather than the one specified by the --python flag.

The `pipenv requirements` command has been added that only pulls from
the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed
to only dump out requirements for the appropriate system
(see pypa/pipenv#5092).
mssalvatore pushed a commit that referenced this issue Mar 1, 2023
@cakekoa @mssalvatore
Project: Use requirements file to install AppImage deps
aa8a0c6 
Switch from using `pipenv sync --system` to using the requirements file
generated from `pipenv requirements`.

The `pipenv sync --system` command (added in #1993)  does not work in
newer versions of pipenv. It uses the python version of the system
rather than the one specified by the --python flag.

The `pipenv requirements` command has been added that only pulls from
the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed
to only dump out requirements for the appropriate system
(see pypa/pipenv#5092).
mssalvatore pushed a commit that referenced this issue Mar 1, 2023
@cakekoa @mssalvatore
Project: Use requirements file to install AppImage deps
65a3332 
Switch from using `pipenv sync --system` to using the requirements file
generated from `pipenv requirements`.

The `pipenv sync --system` command (added in #1993)  does not work in
newer versions of pipenv. It uses the python version of the system
rather than the one specified by the --python flag.

The `pipenv requirements` command has been added that only pulls from
the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed
to only dump out requirements for the appropriate system
(see pypa/pipenv#5092).
mssalvatore pushed a commit that referenced this issue Mar 1, 2023
@cakekoa @mssalvatore
Project: Use requirements file to install AppImage deps
54fd1bd 
Switch from using `pipenv sync --system` to using the requirements file
generated from `pipenv requirements`.

The `pipenv sync --system` command (added in #1993)  does not work in
newer versions of pipenv. It uses the python version of the system
rather than the one specified by the --python flag.

The `pipenv requirements` command has been added that only pulls from
the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed
to only dump out requirements for the appropriate system
(see pypa/pipenv#5092).
mssalvatore pushed a commit that referenced this issue Mar 1, 2023
@cakekoa @mssalvatore
Project: Use requirements file to install AppImage deps
fc095c1 
Switch from using `pipenv sync --system` to using the requirements file
generated from `pipenv requirements`.

The `pipenv sync --system` command (added in #1993)  does not work in
newer versions of pipenv. It uses the python version of the system
rather than the one specified by the --python flag.

The `pipenv requirements` command has been added that only pulls from
the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed
to only dump out requirements for the appropriate system
(see pypa/pipenv#5092).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. sp/3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1993 fix pip platform appimage guardicore/monkey
2 participants
@mssalvatore @VakarisZ