Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1993 fix pip platform appimage #2007

Merged
merged 6 commits into from
Jun 9, 2022
Merged

Conversation

mssalvatore
Copy link
Collaborator

What does this PR do?

Fixes #1993

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by building locally and modifying config through the UI
    Tested by running end-to-end tests

  • If applicable, add screenshots or log transcripts of the feature working

When pipenv dumps the lock file to a requirements.txt, it does not
include the `sys_platform` directive. This causes pip to attempt to
install win32 packages, which fails. By using `pypenv sync --system`
instead, only packages applicable to Linux are installed.

Fixes #1993
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #2007 (cacd064) into develop (b8c4ae8) will decrease coverage by 0.01%.
The diff coverage is 49.20%.

@@             Coverage Diff             @@
##           develop    #2007      +/-   ##
===========================================
- Coverage    56.50%   56.48%   -0.02%     
===========================================
  Files          463      465       +2     
  Lines        12985    13025      +40     
===========================================
+ Hits          7337     7357      +20     
- Misses        5648     5668      +20     
Impacted Files Coverage Δ
...key/infection_monkey/exploit/i_agent_repository.py 83.33% <ø> (ø)
...tory/file_storage/local_storage_file_repository.py 97.77% <ø> (-0.05%) ⬇️
...onkey/monkey_island/cc/resources/agent_binaries.py 46.66% <ø> (+7.64%) ⬆️
monkey/monkey_island/cc/server_setup.py 0.00% <ø> (ø)
monkey/monkey_island/cc/services/initialize.py 0.00% <0.00%> (ø)
...ey_island/cc/repository/agent_binary_repository.py 52.94% <52.94%> (ø)
monkey/common/utils/file_utils.py 100.00% <100.00%> (ø)
monkey/monkey_island/cc/app.py 80.13% <100.00%> (-0.14%) ⬇️
monkey/monkey_island/cc/repository/__init__.py 100.00% <100.00%> (ø)
...nd/cc/repository/file_storage/i_file_repository.py 75.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b2ca74...cacd064. Read the comment docs.

@mssalvatore mssalvatore merged commit 9c8b74d into develop Jun 9, 2022
@mssalvatore mssalvatore deleted the 1993-fix-pip-platform-appimage branch June 9, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Appimage Island build fails
3 participants