Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1993 fix pip platform appimage #2007

Merged
merged 6 commits into from
Jun 9, 2022
Merged

1993 fix pip platform appimage #2007

merged 6 commits into from
Jun 9, 2022

Commits on Jun 9, 2022

  1. Build: Use pipenv sync --system instead of requirements.txt 

    When pipenv dumps the lock file to a requirements.txt, it does not
include the `sys_platform` directive. This causes pip to attempt to
install win32 packages, which fails. By using `pypenv sync --system`
instead, only packages applicable to Linux are installed.

Fixes #1993
    @mssalvatore
    mssalvatore committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    b8a5245 View commit details
    Browse the repository at this point in the history

  2. Build: Handle errors if pushd or popd fail

    @mssalvatore
    mssalvatore committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    f7ad99f View commit details
    Browse the repository at this point in the history

  3. Build: Double quote variables to prevent splitting

    @mssalvatore
    mssalvatore committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    1b6856b View commit details
    Browse the repository at this point in the history

  4. Build: Use braces to expand array

    @mssalvatore
    mssalvatore committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    cd1d7b2 View commit details
    Browse the repository at this point in the history

  5. Build: Uninstall pipenv from AppImage after dependencies are installed

    @mssalvatore
    mssalvatore committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    73d20a6 View commit details
    Browse the repository at this point in the history

  6. Build: Uninstall pipenv and virtualenv after dependencies are installed 

    This reduces the size of the AppImage by 7.4%
    @mssalvatore
    mssalvatore committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    cacd064 View commit details
    Browse the repository at this point in the history