Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CLI to lean more heavily on click's built in functionality #2814

Merged
merged 23 commits into from
Sep 5, 2018
Merged

Refactor CLI to lean more heavily on click's built in functionality #2814

Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
15916af
Refactor CLI options
techalchemy Aug 31, 2018
eb18ed2
Clean up core arguments
techalchemy Aug 31, 2018
228b28b
Update piptools patch
techalchemy Aug 31, 2018
7d57386
Clean up test
techalchemy Aug 31, 2018
8b32e19
Refactor CLI for organization and simplicity
techalchemy Sep 2, 2018
c3b6143
Cleanup unicode literals warnings
techalchemy Sep 2, 2018
305628e
Fix some typos
techalchemy Sep 2, 2018
12217e6
Clean up vcs ref checkouts
techalchemy Sep 2, 2018
597bc8c
Update requirementslib
techalchemy Sep 2, 2018
f93cefa
Fix `lock -r` output to include all markers
techalchemy Sep 2, 2018
f902d8f
Turn off no-deps for tarballs/zips
techalchemy Sep 3, 2018
eb0709b
Fix installation of multiple packages
techalchemy Sep 3, 2018
ab2b3d3
Minor project fixes
techalchemy Sep 3, 2018
86022cc
Add missing skip_lock option
techalchemy Sep 3, 2018
2768edb
Fix editor auto-deletions of piptools patch lines
techalchemy Sep 3, 2018
e88d2d6
No idea why this doesn't work
techalchemy Sep 3, 2018
9cfb863
Syntax error...
techalchemy Sep 3, 2018
661eb17
Reorganize pip installation to ditch custom parser
techalchemy Sep 3, 2018
b33dfa6
Update requirementslib and fix VCS installation
techalchemy Sep 3, 2018
6f7dbe9
Windows edge case and news
techalchemy Sep 4, 2018
b4fa920
Merge branch 'master' into fix-cli
kennethreitz Sep 4, 2018
b2110f9
Fix option in cli and get released requirementslib
techalchemy Sep 4, 2018
69defdf
Merge branch 'fix-cli' of github.com:pypa/pipenv into fix-cli
techalchemy Sep 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions MANIFEST.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ recursive-include docs/_templates *.html
recursive-include docs/_static *.js *.css *.png
recursive-exclude docs requirements*.txt


prune peeps
prune .buildkite
prune .github
prune .vsts-ci
Expand Down
1 change: 1 addition & 0 deletions news/1690.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
VCS Refs for locked local editable dependencies will now update appropriately to the latest hash when running ``pipenv update``.
1 change: 1 addition & 0 deletions news/2173.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
``.tar.gz`` and ``.zip`` artifacts will now have dependencies installed even when they are missing from the lockfile.
1 change: 1 addition & 0 deletions news/2279.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
The command line parser will now handle multiple ``-e/--editable`` dependencies properly via click's option parser to help mitigate future parsing issues.
1 change: 1 addition & 0 deletions news/2494.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed a bug which could cause ``-i/--index`` arguments to sometimes be incorrectly picked up in packages. This is now handled in the command line parser.
1 change: 1 addition & 0 deletions news/2714.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed a bug which could cause the ``-e/--editable`` argument on a dependency to be accidentally parsed as a dependency itself.
1 change: 1 addition & 0 deletions news/2748.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
All markers are now included in ``pipenv lock --requirements`` output.
1 change: 1 addition & 0 deletions news/2760.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed a bug in marker resolution which could cause duplicate and non-deterministic markers.
1 change: 1 addition & 0 deletions news/2766.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed a bug in the dependency resolver which caused regular issues when handling ``setup.py`` based dependency resolution.
1 change: 1 addition & 0 deletions news/2814.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Deduplicate and refactor CLI to use stateful arguments and object passing. See `this issue <https://github.com/pallets/click/issues/108>`_ for reference.
2 changes: 1 addition & 1 deletion pipenv/_compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ class TemporaryDirectory(object):
in it are removed.
"""

def __init__(self, suffix=None, prefix=None, dir=None):
def __init__(self, suffix="", prefix="", dir=None):
if "RAM_DISK" in os.environ:
import uuid

Expand Down
Loading