Fix DeprecationWarning: invalid escape sequence in tests #3426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mickaël Schoentgen <contact@tiger-222.fr>
|
Do you mind link the output of our CI which has this warning? I didn't find our passed Azure CI in windows/linux has these kind of warnings. Thanks! |
jxltom
added
the
Status: Awaiting Update ⏳
|
Oooh I know exactly what this refers to. I would prefer raw strings for this fix though, if you don’t mind! |
jxltom
removed
the
Status: Awaiting Update ⏳
techalchemy
reviewed
Mar 10, 2019
| @@ -218,7 +218,7 @@ def mock_version(path): | |||
| @pytest.mark.windows | |||
| @pytest.mark.skipif(os.name != "nt", reason="Windows test only") | |||
| def test_windows_shellquote(self): | |||
| test_path = "C:\Program Files\Python36\python.exe" | |||
| test_path = r"C:\Program Files\Python36\python.exe" | |||
There was a problem hiding this comment.
Based on the presence of 4 backslashes in the original, I'm guessing you'd need 2 backslashes in a raw string and then this should work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
Fixes
DeprecationWarning: invlid escape sequencein tests.The fix
Use double backslashes (raw strings would have been OK too).
The checklist
news/directory to describe this fix with the extension.bugfix,.feature,.behavior,.doc..vendor. or.trivial(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.I do not think adding a NEWs entry is necessary but correct me if I am wrong :)