Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DeprecationWarning: invalid escape sequence in tests #3426

Closed
wants to merge 11 commits into from
Closed

Fix DeprecationWarning: invalid escape sequence in tests #3426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7f85b22
Fix DeprecationWarning: invalid escape sequence in tests
BoboTiG Jan 5, 2019
5d4c7b1
Use raw strings
BoboTiG Jan 19, 2019
b3213d0
Merge branch 'master' into fix-invalid-seq-warnings
BoboTiG Jan 19, 2019
70c0dd2
Merge branch 'master' into fix-invalid-seq-warnings
BoboTiG Mar 8, 2019
5048ca7
Merge branch 'master' into fix-invalid-seq-warnings
BoboTiG Mar 14, 2019
dadb11d
Merge branch 'master' into fix-invalid-seq-warnings
BoboTiG May 19, 2019
a0221e4
Merge branch 'master' into fix-invalid-seq-warnings
techalchemy May 20, 2019
fe70e8c
Merge branch 'master' into fix-invalid-seq-warnings
techalchemy May 27, 2019
8732568
Merge branch 'master' into fix-invalid-seq-warnings
techalchemy May 27, 2019
5f057b3
Merge branch 'master' into fix-invalid-seq-warnings
techalchemy Jun 4, 2019
1161cd9
Merge branch 'master' into fix-invalid-seq-warnings
BoboTiG Jun 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/integration/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ def test_install_parse_error(PipenvInstance, pypi):
[dev-packages]
""".strip()
f.write(contents)
c = p.pipenv('install requests u/\\/p@r\$34b13+pkg')
c = p.pipenv(r'install requests u/\\/p@r\$34b13+pkg')
assert c.return_code != 0
assert 'u/\\/p@r$34b13+pkg' not in p.pipfile['packages']

Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ def mock_version(path):
@pytest.mark.windows
@pytest.mark.skipif(os.name != "nt", reason="Windows test only")
def test_windows_shellquote(self):
test_path = "C:\Program Files\Python36\python.exe"
test_path = r"C:\Program Files\Python36\python.exe"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the presence of 4 backslashes in the original, I'm guessing you'd need 2 backslashes in a raw string and then this should work

expected_path = '"C:\\\\Program Files\\\\Python36\\\\python.exe"'
assert pipenv.utils.escape_grouped_arguments(test_path) == expected_path

Expand Down