Actually filter out missing interpreters #5262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes pypa#5261. Before this change, I would get a "The Python interpreter can't be found" error when running `pipenv install --system` with a python3 but no python. Demo: ``` $ docker run $(docker build -q -f Dockerfile.pipenv-2022.8.15 https://github.com/jfly/2022-08-16-pipenv-system-which-issue.git#main) Installing dependencies from Pipfile.lock (63bec0)... The Python interpreter can't be found.▉ 0/4 — 00:00:00 🐍 ▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉ 0/4 — 00:00:00 ``` I'm confident this bug was introduced in pypa@f276360, which removed a usage of `first()`, but broke the "filter None values" behavior that `first()` gave us.
This build just failed https://github.com/pypa/pipenv/runs/7853944342?check_suite_focus=true with the following error: NEWS fragment files must be named *.(feature|behavior|bugfix|vendor|doc|trivial|removal|process).rst news/5261.bugfix pre-commit hook(s) made changes. If you are seeing this message in CI, reproduce locally with: `pre-commit run --all-files`. I created this file by following the PR template instructions, which don't say anything about the `.rst` part of the filename. I'm fixing up those instructions while I'm in here as well.
jfly
force-pushed
the
jfly/fix-which-system-issue
branch
from
5b95b61
to
41881f2
Compare
|
Hmm... the test suite failed in |
|
@jfly I've been fighting those test failures, mostly on mac OS, for about a month now. It seems to have started around the time I converted off pip-shims in pipenv, but I cannot be certain nor can I explain why its happening. Its high on my list of things to figure out. |
matteius
approved these changes
Aug 16, 2022
yeisonvargasf
pushed a commit
to yeisonvargasf/pipenv
that referenced
this pull request
Nov 19, 2022
* Actually filter out missing interpreters This fixes pypa#5261. Before this change, I would get a "The Python interpreter can't be found" error when running `pipenv install --system` with a python3 but no python.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5261.
Before this change, I would get a "The Python interpreter can't be
found" error when running
pipenv install --systemwith a python3 butno python.
Demo:
I'm confident this bug was introduced in
f276360,
which removed a usage of
first(), but broke the "filter None values"behavior that
first()gave us.The checklist
news/directory to describe this fix with the extension.bugfix,.feature,.behavior,.doc..vendor. or.trivial(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.