Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually filter out missing interpreters #5262

Merged
merged 3 commits into from
Aug 16, 2022
Merged

Actually filter out missing interpreters #5262

merged 3 commits into from
Aug 16, 2022

Commits on Aug 16, 2022

  1. Actually filter out missing interpreters 

    This fixes pypa#5261.

Before this change, I would get a "The Python interpreter can't be
found" error when running `pipenv install --system` with a python3 but
no python.

Demo:

```
$ docker run $(docker build -q -f Dockerfile.pipenv-2022.8.15 https://github.com/jfly/2022-08-16-pipenv-system-which-issue.git#main)
Installing dependencies from Pipfile.lock (63bec0)...
The Python interpreter can't be found.▉ 0/4 — 00:00:00
  🐍   ▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉ 0/4 — 00:00:00
```

I'm confident this bug was introduced in
pypa@f276360,
which removed a usage of `first()`, but broke the "filter None values"
behavior that `first()` gave us.
    @jfly
    jfly committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    0e629d3 View commit details
    Browse the repository at this point in the history

  2. Rename NEWS fragment 

    This build just failed
https://github.com/pypa/pipenv/runs/7853944342?check_suite_focus=true
with the following error:

    NEWS fragment files must be named *.(feature|behavior|bugfix|vendor|doc|trivial|removal|process).rst

    news/5261.bugfix

    pre-commit hook(s) made changes.
    If you are seeing this message in CI, reproduce locally with: `pre-commit run --all-files`.

I created this file by following the PR template instructions, which
don't say anything about the `.rst` part of the filename. I'm fixing up
those instructions while I'm in here as well.
    @jfly
    jfly committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    d06a811 View commit details
    Browse the repository at this point in the history

  3. Remove trailing whitepace in README to get tests passing

    @jfly
    jfly committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    41881f2 View commit details
    Browse the repository at this point in the history