Safer usages of pkg_resources #5350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
|
Will depend on actually vendoring in this sarugaku/requirementslib#343 with a new release of requirementslib, but I have the changes in place now for testing. |
|
I have vendor'd in the new requirementslib release so this is ready for review. |
matteius
added
the
PR: awaiting-review
oz123
approved these changes
Sep 14, 2022
oz123
removed
the
PR: awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5349
Fixes #5208
The issue
__main__.pywhich is a more modern way using importlib that does not rely on pkg_resoruces.vendoring.updatetask by adding it to theLIBRARY_RENAMESand reinvoke thevendoring.updatetask which rewrote the imports.