Rely on packaging and pkg_resources internal to pip. #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This opens the door to rewriting all of the pkg_resources imports in pipenv to come from
pip._vendor.pkg_resources-- If I do this now in pipenv it breaks vcs dependency requirements because it imports from an incompatible path in some places in requirements. The nice thing, is by heading in this direction, it has eliminated these style warnings for me locally which we also get a lot of reports about: pypa/pipenv#5208Additionally this should help with: pypa/pipenv#5349
This also fixes the issue where tests were not passing with the latest version of pyparsing.
Fixes #181
This was realized when I re-wrote the imports here and it broke 3 vcs related tests: pypa/pipenv#5350
Note about the spaces before the ; -- pypa/packaging#529