-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce towncrier #1201
Introduce towncrier #1201
Conversation
Just realized this needs a bit more work like updating the CONTRIBUTING.md, so I'll mark this as draft for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this! I had already started this review so I'm submitting regardless of the draft status.
Yes, CONTRIBUTING.md
will need to be updated. Also, we'll have to refactor our changelog CI process.
Co-authored-by: chrysle <fritzihab@posteo.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have mostly copied the |
I hope my change should be all that is necessary. Most other repos in pypa I have checked that use towncrier have a manual step to do the changelog build. Not sure if there's a reason for it. |
This project wants to avoid that. PyPA is not a unified project set, we each do what works best for us. |
You have some merge conflicts to resolve first 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a changelog entry so we can see it showing up here https://pipx--1201.org.readthedocs.build/1201/changelog
Also I don't want to see this:
This project uses [towncrier](https://towncrier.readthedocs.io/) and the changes for the upcoming release can be found in https://github.com/twisted/my-project/tree/main/changelog.d/.
on the changelog entry.
Instead, we should change the doc generation to include it in-line. That way we can see how the changelog will look post release as part of the PR.
See virtualenv doing this https://github.com/pypa/virtualenv/blob/main/docs/conf.py#L54
Co-authored-by: chrysle <fritzihab@posteo.de>
I've done this now. 2 things to note:
Please ignore conflicts in the Edit: |
Thanks @gaborbernat @chrysle with your thorough support and suggestions for getting this out there :) Much appreciated! |
Thanks for making it happen 👍 |
I'm going along with that! |
This did fail in the latest release, see https://github.com/pypa/pipx/actions/runs/7544497267/job/20539252092 @Gitznik can you take a look please? |
Probably running |
Yeah I'm testing installing it first instead of running directly. That fixed the problem for me locally. |
docs/changelog.md
Summary of changes
As suggested in #1161, this introduces towncrier for managing the changelog. @chrysle I hope you're fine with me doing some work on this. I really wanted to stop having conflicts in the changelog ;)
I've updated the changelog for all releases since 1.0, excluding linking the issues.
I've updated the current open changelog entries to be towncrier news fragements.
I've pretty much stuck to the default configuration suggested by towncrier. Please let me know if you have any other preferences.
Closes #1161.
The current open changelog items would be added to the changelog like this:
towncrier build --version 1.5.0
1.5.0 - 2024-01-11
Added
Changed
pipx run
on scripts using/// script
and norun
table following the updated version of PEP 723 (#1180)Fixed
--python
version is not found (#1089)pipx run
: Verify whether the script name provided is a file before running it (#1152)