Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix towncrier build #1213

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Fix towncrier build #1213

merged 4 commits into from
Jan 16, 2024

Conversation

Gitznik
Copy link
Contributor

@Gitznik Gitznik commented Jan 16, 2024

  • I have added a news fragment under changelog.d/ (if the patch affects the end users)

Summary of changes

This fixes the error in the pipeline as reported in #1201 (comment)

@gaborbernat

running pipx install towncrier and then running towncrier build fixed it for me locally, but not in the pipeline.

Test plan

See https://github.com/Gitznik/pipx/actions/runs/7545283319/job/20540558260

Tested by running

# command(s) to exercise these changes

Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat enabled auto-merge (squash) January 16, 2024 19:55
@gaborbernat gaborbernat merged commit 2cf78d2 into pypa:main Jan 16, 2024
14 checks passed
@gaborbernat
Copy link
Contributor

@Gitznik can you put in one more PR to clean up this failed batch https://github.com/pypa/pipx/tree/main/changelog.d :-D from the last release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants