-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement declarative config for compatibility with setuptools declarative config #364
Conversation
…istribution_options' entry point.
d831c25
to
d1e6c60
Compare
Still to do:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this,
the setup keyword can actually stay relatively easy with this,
Could setuptools provide a helper to get the settings section from pyproject.toml
Thanks!
Unfortunately, setuptools itself doesn't yet have toml (or pyproject.toml) support... but it might be worthwhile for setuptools to own that functionality to avoid plugins needing to own the parsing. How much harm is it for setuptools_scm to have a dependency (toml)? |
its a pain for anyone using the legacy support as it will pull in toml via easy_install so having a toml dependency outside of what setuptools does would be a big blow for backward compat its possible to make it a extra dependency |
@jaraco got thinking again, its easy to have a extra and a optional import, after all - i can sort out most of the pain i believe (bit it would still be much nicer if the toml data was readily available in some way) |
Are there scenarios where requiring a pure-python source distribution wouldn't work as a simple dependency (as toml installs under easy_install)? I'm not opposed to finding another solution, but I'd like to know what scenario we're seeking to solve.
Oh, so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is shaping up nicely, I like it
Co-Authored-By: Ronny Pfannschmidt <opensource@ronnypfannschmidt.de>
…' section to enable the functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work, what about the wip status
I've got a few more commits to address the docs. |
d267389
to
0fa6272
Compare
thanks for implementing and documenting this with this fabulous work many are finally free of i plan to release mid week after including the ci/pre-commit fixups |
|
||
This feature requires Setuptools 42 or later, released in Nov, 2019. | ||
If your project needs to support build from sdist on older versions | ||
of Setuptools, you will need to also implement the ``setup.py usage`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you placed the closing backticks too far...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't quite sure how to handle that, given that the backticks are in the title. I'm happy to accept edits on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. I'm not sure either. Could probably try using a link syntax.
Just chiming in to say FUCK YEAH. Thanks! One less file lying around 👍 |
Fixes #181
In irc.freenode.net#pylib, Ronny asked about supporting setuptools_scm on setuptools in a declarative config world. This change illustrates how I'd propose for that to happen. Setuptools would expose a new hook, something like
https://gist.github.com/b45998781be03918a21f17da996ee687
And then setuptools_scm would provide a hook into that such as the one (building on all of the existing work already done).