-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow opt-out of find_files behavior. (issue 561) #851
base: main
Are you sure you want to change the base?
Conversation
Changes it so find_files is only enabled with config parameter `enable_find_files` is set to true, otherwise will always return empty list.
1772b25
to
819fbad
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for legacy support this has to be opt-in
im researching ways to enable this better by adding a new sdist subcommand instead of obtaining a unrelated possibly miss-configured config object for just the file listing
OK, I've switched the default to true. |
isn't this PR good to be merged now the requested changes have been made ? |
cant merge this yet as opting out of the file finders possibly opts into version finding + there is a bug |
@RonnyPfannschmidt Do you have more information, e.g. what is the bug that is preventing this being merged? |
@daveware-nv looks like the PR title needs to be fixed to reflect the post-review changes. Could you update it? |
currently there are many merge conflicts - im unable to merge as is in the next major release i want to switch from file finders to custom setuptools subcommands as currently file finder opt out requires setuptools_scm "opt-in" |
In #364 (comment), I advocated for there being a separate boolean to enable (or disable) version inference. Probably that needs to be implemented (first) so people can opt out of versions inference as well. Either that, or the |
Changes it so find_files is only enabled with config parameterenable_find_files
is set to true, otherwise will always return empty list.Adds config argument
enable_find_files
that when set tofalse
allowsfind_files
behavior to be disabled.Addresses #561