Remove implementation code from main import + replace write_to with version_file #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still needs function renames
also splits up the get version logic and introduces a type for the parse function
RonnyPfannschmidt
changed the title
antazoey
reviewed
Sep 20, 2023
|
|
||
| .. warning:: | ||
|
|
||
| its strongly recommended to use use distribution name specific pretend versions |
There was a problem hiding this comment.
There is a random extra space here.
|
|
||
| .. warning:: | ||
|
|
||
| its strongly recommended to use use distribution name specific pretend versions |
There was a problem hiding this comment.
It should be either it's or it is. its means something else.
| local_scheme=config.local_scheme, | ||
| ) | ||
| if config.write_to is not None: | ||
| dump_version( |
There was a problem hiding this comment.
my version file is no longer being dumped anywhere and I am trying to figure out why.
3 tasks
GDYendell
added a commit
to DiamondLightSource/python-copier-template
that referenced
this pull request
Jul 12, 2024
This changed in v8.0.0 via pypa/setuptools-scm#870
GDYendell
added a commit
to DiamondLightSource/python-copier-template
that referenced
this pull request
Jul 19, 2024
This changed in v8.0.0 via pypa/setuptools-scm#870
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #188
closes #875