Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct word and space in SETUPTOOLS_SCM_PRETEND_VERSION warning #917

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

antazoey
Copy link
Contributor

  • Replaces its with it is. The word its means something else; it's was definitely intended.
  • Removes an extra space.

NOTE: I am debugging my project's version files are no longer being generated, both locally and in CI but I came across this doc issue so I thought I'd open the PR... But really, my priority here is to figure out why my version file doesn't get created anymore. I tried switching write_to to version_file but that did not seem to work.

I have been looking at #870 to try and find answers.

@antazoey antazoey changed the title docs: correct word and space docs: correct word and space in version_file warning Sep 20, 2023
@antazoey antazoey changed the title docs: correct word and space in version_file warning docs: correct word and space in SETUPTOOLS_SCM_PRETEND_VERSION warning Sep 20, 2023
@antazoey
Copy link
Contributor Author

Perhaps I should open a separate issue, but I am having to pin <8 on my project because the version file refuses to generate. I am guessing I am doing something wrong but I can't figure out what. I am going to keep debugging.

@RonnyPfannschmidt
Copy link
Contributor

pleae create a own issue and addthe output when using SETUPTOOLS_SCM_DEBUG while building

@antazoey
Copy link
Contributor Author

It sounds like my issue may be this one: #919

@RonnyPfannschmidt RonnyPfannschmidt merged commit 9d6ab45 into pypa:main Sep 21, 2023
18 checks passed
@RonnyPfannschmidt
Copy link
Contributor

thanks for those fixes 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants