Handle wave of overdue deprecations #4066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abravalheri
force-pushed
the
deprecations
branch
from
40ed2aa
to
e26bda4
Compare
A search in [`grep.app`](https://grep.app/search?q=%5Erequires%5Cs%2A%3D®exp=true&filter%5Bpath.pattern%5D%5B0%5D=setup.cfg) suggests that `requires` is not utilised in `setup.cfg`, so it should be safe to remove. `license_file` is not fundamental to make distributions work, so it should be safe to remove.
This interface is not super stable/usable yet, so it should be fine to remove.
… and post-pone deprecations for `setup.cfg` regarding hifens instead of underscores and upper-cased fields.
This way we don't have to see `DistutilsOptionError` in the error message.
abravalheri
force-pushed
the
deprecations
branch
from
e26bda4
to
b243818
Compare
|
Updated to include more overdue deprecations for Oct 2023. |
abravalheri
force-pushed
the
deprecations
branch
from
6553a44
to
b97814a
Compare
abravalheri
commented
Nov 20, 2023
In `pip` docs, the following example is mentioned: > python -m pip wheel --global-option bdist_ext --global-option -DFOO wheel Since both `--global-option` and `--build-option` are supposed to be compatible with `pip` options, we should not prevent this abuse... (Although it is still error prone and the user is responsible for understanding in detail what is going on how this accidentally works).
abravalheri
force-pushed
the
deprecations
branch
from
1f0f66c
to
a5a7505
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some deprecation warnings have been marked as due. Note that they were announced as deprecated at least a year ago (likely more than 1).
Summary of changes
setup.cfgthat have hyphens instead of underscores or are upper-cased.sdistspublished to PyPI so I postponed this change for another year...setuptools._normalization.best_effort_versioncan be used internally (this function will try very hard to sanitise the given version string).egg_baseoption fromdist_info.dist_infois kind of an internal command that was created for the PEP 517 implementation, so we don't have much commitment in providing a public API for it.metadata.requiresfromsetup.cfg.options.install_requiresgrep.appsuggests thatmetadata.requiresis not utilised insetup.cfg, so it should be safe to remove.metadata.license_filefromsetup.cfg.license_fileis not going to break core functionality of files, so it is low stakes.config_settings--global-optionconfig_settingsis not very stable/usable. We still have lots of work on that regards...namespace-packagesfrompyproject.toml.implicit namespace packages <PyPUG:guides/packaging-namespace-packages>(as defined in :pep:420).project.dynamicinpyproject.toml.setup.pywithout making the necessary changes topyproject.toml(as mandated by :pep:612).@jaraco please let me know if you have any objection/suggestion regarding this.
Pull Request Checklist
newsfragments/.(See documentation for details)