Support loading version from a file #1359
Merged
+37
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't tried this on live code, but it looks nice! |
idlesign
approved these changes
May 15, 2018
|
I think I'm more or less fine with this, except that I think the resulting string should be more constrained. Per discussion at PyCon sprints, we should just start by validating that it's a valid PEP 440 version, and if people complain about this restriction we can possibly add a mechanism for opting out. |
jmbowman
force-pushed
the
jmbowman/version_from_file
branch
from
7eeaa83 to
a960ee1
Compare
jaraco
pushed a commit
to jaraco/cpython
that referenced
this pull request
Feb 17, 2023
This support was added in (pypa/setuptools#1359), which was quite a while ago, so I believe it is safe to use this feature now and expect people to be able to process this metadata format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed resolution for #1358. Adds support for using "file:" to load the package version from a text file. It strips any leading or trailing whitespace, since trailing newlines are pretty likely in such a file.