Use "source" as python-version for sdist uploads #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnicolodi
force-pushed
the
sdist-pyversion
branch
from
21b1626 to
8c02caa
Compare
woodruffw
reviewed
Dec 3, 2024
There was a problem hiding this comment.
LGTM behaviorally -- I confirmed this against Warehouse's form validation for pyversion here:
@dnicolodi Could you add a short unit test for this? Thanks!
Although not setting the "pyversion" field in the upload data works, and despite it not being used for much, this is what PyPI (and most likely other indexes) expects. This will simplify follow-up patches.
dnicolodi
force-pushed
the
sdist-pyversion
branch
from
8c02caa to
3449942
Compare
Added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although not setting the "pyversion" field in the upload data works, and despite it not being used for much, this is what PyPI (and most likely other indexes) expects.
This will simplify follow-up patches.