Remove egg and wininst support #1195
Conversation
dnicolodi
force-pushed
the
rm-egg-wininst
branch
from
e2da426 to
d2de241
Compare
|
As discussed in #1190 (comment). Replaces #1192. |
dnicolodi
force-pushed
the
rm-egg-wininst
branch
2 times, most recently
from
50be486 to
7022e65
Compare
|
Thanks @dnicolodi -- like with #1191, could you add a small test here? A simple negative/backstop test to ensure that |
|
I will jump through the hoop, just for the sake of getting this moving. However, this PR does not change how unrecognized files are handled thus I don't see why only now it becomes important that this aspect is tested... |
dnicolodi
force-pushed
the
rm-egg-wininst
branch
from
7022e65 to
c4989a7
Compare
|
Test added. |
|
Thanks.
I'm a big believer in negative tests -- I think they make it easier to detect regressions and other unplanned changes. The fact that there wasn't a negative test here already isn't a good reason to not add one IMO 🙂 |
PyPI does not accept these distribution types since August 2023 and there are no modern build backends that produce these, thus they are most likely not used anymore. egg support has only very minimal test coverage and had a fairly obvious although likely inconsequential bug in reporting the target Python version. wininst support has no tests.
dnicolodi
force-pushed
the
rm-egg-wininst
branch
from
c4989a7 to
f3a0a1f
Compare
PyPI does not accept these distribution types since August 2023 and there are no modern build backends that produce these, thus they are most likely not used anymore.
egg support has only very minimal test coverage and had a fairly obvious although likely inconsequential bug in reporting the target Python version. wininst support has no tests.