-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
activate.nu
is not respecting VIRTUAL_ENV_DISABLE_PROMPT
#2461
Labels
Comments
gaborbernat
pushed a commit
that referenced
this issue
Dec 5, 2022
github-actions bot
added a commit
to MaRDI4NFDI/open-interfaces
that referenced
this issue
Dec 12, 2022
Bumps [virtualenv](https://github.com/pypa/virtualenv) from 20.17.0 to 20.17.1. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pypa/virtualenv/blob/main/docs/changelog.rst">virtualenv's changelog</a>.</em></p> <blockquote> <h2>v20.17.1 (2022-12-05)</h2> <p>Bugfixes - 20.17.1</p> <pre><code>- A ``py`` or ``python`` spec means any Python rather than ``CPython`` - by :user:`gaborbernat`. (`[#2460](pypa/virtualenv#2460) <https://github.com/pypa/virtualenv/issues/2460>`_) - Make ``activate.nu`` respect ``VIRTUAL_ENV_DISABLE_PROMPT`` and not set the prompt if reqeusted - by :user:`m-lima`. (`[#2461](pypa/virtualenv#2461) <https://github.com/pypa/virtualenv/issues/2461>`_) </code></pre> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pypa/virtualenv/commit/63d5a3ceaf66441542da951914f34d8c1951ab28"><code>63d5a3c</code></a> release 20.17.1</li> <li><a href="https://github.com/pypa/virtualenv/commit/d3215e4b3c1db93c7591ed68d20dc3c62fe0b03b"><code>d3215e4</code></a> Respect <code>VIRTUAL_ENV_DISABLE_PROMPT</code> in nushell activation script (<a href="https://github-redirect.dependabot.com/pypa/virtualenv/issues/2458">#2458</a>)</li> <li><a href="https://github.com/pypa/virtualenv/commit/28f40672503974bdbf2c83d5174b738dcf45a5e5"><code>28f4067</code></a> Py marker means any python not CPython (<a href="https://github-redirect.dependabot.com/pypa/virtualenv/issues/2460">#2460</a>)</li> <li><a href="https://github.com/pypa/virtualenv/commit/da9262539911fa0c6efb01bff3843aeb74843d87"><code>da92625</code></a> Bump pypa/gh-action-pypi-publish from 1.5.2 to 1.6.1 (<a href="https://github-redirect.dependabot.com/pypa/virtualenv/issues/2459">#2459</a>)</li> <li><a href="https://github.com/pypa/virtualenv/commit/87d9a5bb0afea6a9166e4f1fdcf0ea6632922399"><code>87d9a5b</code></a> Bump pypa/gh-action-pypi-publish from 1.5.1 to 1.5.2 (<a href="https://github-redirect.dependabot.com/pypa/virtualenv/issues/2454">#2454</a>)</li> <li><a href="https://github.com/pypa/virtualenv/commit/a95e5e789dda9f4f704716ec35e92819be5bef69"><code>a95e5e7</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/pypa/virtualenv/issues/2452">#2452</a> from pypa/release-20.17.0</li> <li>See full diff in <a href="https://github.com/pypa/virtualenv/compare/20.17.0...20.17.1">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=virtualenv&package-manager=pip&previous-version=20.17.0&new-version=20.17.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue
Other activation scripts monitor the env var
VIRTUAL_ENV_DISABLE_PROMPT
to decide if the prompt should be changed or not.activate.nu
, however, does not do soEnvironment
Output of the virtual environment creation
The activation itself has no issues and works as expected. It's just the prompt that is unconditionally changed for nushell
The text was updated successfully, but these errors were encountered: