Respect VIRTUAL_ENV_DISABLE_PROMPT
in nushell activation script
#2458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
activate.nu
script was not respecting theVIRTUAL_ENV_DISABLE_PROMPT
like other scripts. This PR addresses that.The changes can be summarized as:
$env.VIRTUAL_ENV_DISABLE_PROMPT
evaluates tofalse
into bool
built-in, anything that nushell can covert into afalse
will also work, e.g. the stringsfalse
and0000
or0.0
.There are no changes to the documentation since this is already an expected behavior.
Also, I did not add an entry to the changelog as the developer documentation states that "non trivial" changes should be added. I considered this change trivial, but please let me know if an entry is required.
Fixes: #2461