Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Settings UI: Search case sensitivity #2810

Merged
merged 3 commits into from
Feb 25, 2022
Merged

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Search in settings is not case sensitive.

Description

Case sensitivity is not welcommed as searching of jpeg won't find JPEG.

Changes

  • regex is case insensitive
  • fixed filter text change timer to be singleshot
  • fixed issue with missing entity on reset which can happen if schema is invalid or there was an issue with creation

Testing notes:

  1. Open settings UI
  2. Open search dialog (CTRL + f)
  3. Find something with wrong case sensitivity

@iLLiCiTiT iLLiCiTiT self-assigned this Feb 25, 2022
@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Feb 25, 2022
@@ -75,6 +75,7 @@ def __init__(self, parent):

filter_changed_timer = QtCore.QTimer()
filter_changed_timer.setInterval(200)
filter_changed_timer.setSingleShot(True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch. :)

Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@iLLiCiTiT iLLiCiTiT merged commit df59a39 into develop Feb 25, 2022
@iLLiCiTiT iLLiCiTiT deleted the bugfix/search_case_sensitivity branch February 28, 2022 16:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants