This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Feature/pype 754 review burnin filtering #103

Merged

mkolar merged 76 commits into develop from feature/PYPE-754_review_burnin_filtering

May 25, 2020

+2,042 −99

Member

iLLiCiTiT commented Apr 27, 2020 •

edited

Loading

Extract review

Split into smaller methods.
Presets can be very explicit with profile filtering.
Profiles can be specified for host, task and main family or combination of them.
Each profile have it's output definitions and may have set multiple outputs.
- Output definitions contain information about output - filename suffix, extension, width, height or additional ffmpeg arguments.
- Output definitions may be also filtered by representation tags or by all instance families or combination of all families.
  - EXAMPLE: ["review", ["ftrack", "plate"]] output definition will be used only if instance has "review" family or both "ftrack" and "plate" families.
- Output definitions can set additional tags for new representation (like "sequence", "burnin", etc.).
- All keys are optional except "filename suffix" which is dictionary key. Not set keys are skipped. If they must be set then values from input or instance are used (for extension, witdth, height, fps, etc.).

Extract review slates

Not tested yet

Plugin had to be modified to match new Extract review keys.

Extract Burnin

has 2 global keys "options" and "fields"
- "options" may contain options for setting burnin attributes like opacity, color, font, font color, etc. is optional, default options are set in plugin.
- "fields" may contain global burnin values which will be used in all definitions if are not overriden (I would like to remove this key if it's possible, don't think there will be so many burnin definitions that clients want create global values)
Extract burnin has same profile filtering.
- You can have multiple profiles filtered by host, task and main instance family and most matching profile is used
Each profile has "burnins" where key represents filename suffix and value is dictionary where burnins are defined.
Burnin definition may containt "{burnin position}": "{burnin value}", "options" overrides or "filter" where is possible to specify "families" and "tags" filter same as ExtractReview

Notes

Legacy process methods were kept to not break production with already set presets. I've kept them untouched which may cause issues due to PEP, so please ignore PEP in legacy_process methods.

Enhanced image sequence processing. Codec passing to burnin script should not be necessary now, but please test - worked for me but I don't know everything about proper codec settings.

Documentation MUST be done as soon as possible! (that's note for me)

iLLiCiTiT added 19 commits

April 21, 2020 19:28


initial commit for review and burnin filtering


filter_profiles_by_data renamed to find_matching_profile and swaped a…

…rguments in validate_value_by_regexes


find_matching_profile has more complex system of getting most matchin…

06f0312

…g profile when more than one profile was filtered


added filter_outputs_by_tags to filter outputs per representation

f84d9dc


added first step of representation loop

a4a1d0b


added image/view exts and supported exts

bf59ec9


first step of representations loop

dfc3249


few more steps and added few comments

0586fff


process is splitted more than already was

9ed201c


all except reformatting should work

cc153ac


fixed typo

ed84cf2


added ffrpobe streams getting

2e85ef7


extract should work now

a8a2efa


few final touches

b011caa


added profile_exclusion

673e531


make sure always is accessible path to one input file

c553732


input resolution is not taken from instance data but from input source

f267476


use instance resolution for output before using input's resolution

fcc664f


extract review slate match new extract review and count values per ea…

446b91e

…ch representation not per instance

iLLiCiTiT self-assigned this

iLLiCiTiT requested review from antirotor, jakubjezek001 and mkolar

April 27, 2020 14:45

iLLiCiTiT commented

View reviewed changes

pype/plugins/global/publish/extract_review.py Outdated

+ "New representation tags: `{}`".format(new_repre["tags"])
+ )
+ # # QUESTION Why the hell we were adding tags to families?

Member Author

iLLiCiTiT Apr 27, 2020

Who knows why we did this?

Member

mkolar Apr 29, 2020

no idea to be honest. I"m afraid it might be rubish from the first implementation. Sheck if it's used anywhere and get rid of it.

iLLiCiTiT commented

View reviewed changes

pype/plugins/global/publish/extract_review.py Outdated

+ )
+ elif temp_data["without_handles"]:
+ # QUESTION Shall we change this to use filter:

Member Author

iLLiCiTiT Apr 27, 2020

This is not required, but it would be nice to have :)

Member

jakubjezek001 May 19, 2020

If you have tested it and it worked for you then I am up for it. I would be better to have frame based workflow rather then seconds

Member Author

iLLiCiTiT May 19, 2020

Tested, but not all cases. I'll rather create new issue for future PR.

iLLiCiTiT commented

View reviewed changes

pype/plugins/global/publish/extract_review.py Outdated

+ ffmpeg_input_args.append("-y")
+ if temp_data["without_handles"]:
+ # NOTE used `-frames:v` instead of `-t` - should work the same way

Member Author

iLLiCiTiT Apr 27, 2020

This change is not tested!!!

iLLiCiTiT commented

View reviewed changes

pype/plugins/global/publish/extract_review.py

+ return audio_in_args, audio_filters, audio_out_args
+ for audio in audio_inputs:
+ # NOTE modified, always was expected "frameStartFtrack" which is

Member Author

iLLiCiTiT Apr 27, 2020

Audio inputs always expected "frameStartFtrack" key in instance. I think it's not OK...

Member

mkolar Apr 29, 2020

definitely not ok.

Member

jakubjezek001 May 19, 2020

this is just (frame_start - handle_start) as far as I know

iLLiCiTiT commented

View reviewed changes

pype/plugins/global/publish/extract_review.py

+ # Need to merge audio if there are more than 1 input.
+ if len(audio_inputs) > 1:
+ audio_out_args.append("-filter_complex amerge")
+ audio_out_args.append("-ac {}".format(len(audio_inputs)))

Member Author

iLLiCiTiT Apr 27, 2020

Is this ok? I've changed from "-ac 2" to "-ac {}".format(len(audio_inputs)) by FFmpeg documentation https://ffmpeg.org/ffmpeg-all.html#Audio-Options

Member

jakubjezek001 May 20, 2020

Definitely good idea to have this procedural. Not that we are using somewhere more then to channels per input. Well is this actually reflecting 2 as channels or input of files? If the audio_inputs is list of files that this is false value. It should be run trough ffprobe to check channels.

Member Author

iLLiCiTiT May 20, 2020

audio_args require more changes than this. I would like to make those changes in different PR since audio is not used right now, I don't know how it should work and it would take a long time to find out.

iLLiCiTiT commented

View reviewed changes

pype/plugins/global/publish/extract_review.py Outdated Show resolved Hide resolved

iLLiCiTiT commented

View reviewed changes

pype/plugins/global/publish/extract_review.py Outdated

+ ffmpeg_audio_filters.extend(audio_filters)
+ ffmpeg_output_args.extend(audio_out_args)
+ # QUESTION what if audio is shoter than video?

Member Author

iLLiCiTiT Apr 27, 2020

I'm not sure if -shortest should be used here. I would expect to force video duration, maybe?

Member

mkolar Apr 29, 2020

I"d say that audio should never dictate the video length. Not in our usage. However we can certainly have shorter audio and it doesn't always start at 0. For example if animator has to extend a shot in Maya, but doesn't get new extended audio, the result should match the Maya timeline exactly.

Member Author

iLLiCiTiT Apr 29, 2020

FIXED: Found another approach to this with setting "-frames {video length}" argument (hopefully works)

iLLiCiTiT added 4 commits

May 20, 2020 16:03


updated legacy code with latest develop

f4a0157


Merge branch 'develop' into feature/PYPE-754_review_burnin_filtering

6cc864d


also check pixel_aspect in skipping part

774d5de


removed doubled process method

0a07803

hound bot reviewed

View reviewed changes

pype/plugins/global/publish/extract_review.py


		return filtered_outputs

		def legacy_process(self, instance):

hound bot May 20, 2020

'ExtractReview.legacy_process' is too complex (42)

iLLiCiTiT added 3 commits

May 21, 2020 10:05


changed comment and docstring by comments

3a6ab54


boolean variables are easier to see now by comments

fe77756


update changes from PR extract review reformat issue #166

179f0e2

hound bot reviewed

View reviewed changes

hound bot left a comment

Some files could not be reviewed due to errors:

Traceback (most recent call last):

Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 11, in 
    sys.exit(main())
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/cli.py", line 18, in main
    app.run(argv)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 393, in run
    self._run(argv)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 381, in _run
    self.run_checks()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 300, in run_checks
    self.file_checker_manager.run()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 331, in run
    self.run_serial()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 315, in run_serial
    checker.run_checks()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 598, in run_checks
    self.run_ast_checks()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 502, in run_ast_checks
    for (line_number, offset, text, check) in runner:
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 56, in run
    parser.visit(self.tree)
  File "/usr/lib/python3.6/ast.py", line 253, in visit
    return visitor(node)
  File "/usr/lib/python3.6/ast.py", line 261, in generic_visit
    self.visit(item)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 39, in visit_ClassDef
    self.capture_issues_visitor('ClassDef', node)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 33, in capture_issues_visitor
    self.generic_visit(node)
  File "/usr/lib/python3.6/ast.py", line 263, in generic_visit
    self.visit(value)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 36, in visit_Call
    self.capture_issues_visitor('Call', node)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 30, in capture_issues_visitor
    issues = checker.run(node)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checkers/render.py", line 22, in run
    if isinstance(arg, ast.Call) and arg.func.id == 'locals':
AttributeError: 'Attribute' object has no attribute 'id'


add profile from input if is set in extract burnin

5203bb3

hound bot reviewed

View reviewed changes

hound bot left a comment

Some files could not be reviewed due to errors:

Traceback (most recent call last):

Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 11, in 
    sys.exit(main())
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/cli.py", line 18, in main
    app.run(argv)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 393, in run
    self._run(argv)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 381, in _run
    self.run_checks()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 300, in run_checks
    self.file_checker_manager.run()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 331, in run
    self.run_serial()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 315, in run_serial
    checker.run_checks()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 598, in run_checks
    self.run_ast_checks()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 502, in run_ast_checks
    for (line_number, offset, text, check) in runner:
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 56, in run
    parser.visit(self.tree)
  File "/usr/lib/python3.6/ast.py", line 253, in visit
    return visitor(node)
  File "/usr/lib/python3.6/ast.py", line 261, in generic_visit
    self.visit(item)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 39, in visit_ClassDef
    self.capture_issues_visitor('ClassDef', node)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 33, in capture_issues_visitor
    self.generic_visit(node)
  File "/usr/lib/python3.6/ast.py", line 263, in generic_visit
    self.visit(value)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 36, in visit_Call
    self.capture_issues_visitor('Call', node)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 30, in capture_issues_visitor
    issues = checker.run(node)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checkers/render.py", line 22, in run
    if isinstance(arg, ast.Call) and arg.func.id == 'locals':
AttributeError: 'Attribute' object has no attribute 'id'

iLLiCiTiT added 3 commits

May 21, 2020 18:27


use slate's inputs resolution instead of using resolution from instan…

b5fbf1a

…ce or representation


do not use output arguments from output definition


moved -y ffmpeg arg to output args

8645ee1

hound bot reviewed

View reviewed changes

hound bot left a comment

Some files could not be reviewed due to errors:

Traceback (most recent call last):

Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 11, in 
    sys.exit(main())
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/cli.py", line 18, in main
    app.run(argv)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 393, in run
    self._run(argv)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 381, in _run
    self.run_checks()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 300, in run_checks
    self.file_checker_manager.run()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 331, in run
    self.run_serial()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 315, in run_serial
    checker.run_checks()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 598, in run_checks
    self.run_ast_checks()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 502, in run_ast_checks
    for (line_number, offset, text, check) in runner:
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 56, in run
    parser.visit(self.tree)
  File "/usr/lib/python3.6/ast.py", line 253, in visit
    return visitor(node)
  File "/usr/lib/python3.6/ast.py", line 261, in generic_visit
    self.visit(item)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 39, in visit_ClassDef
    self.capture_issues_visitor('ClassDef', node)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 33, in capture_issues_visitor
    self.generic_visit(node)
  File "/usr/lib/python3.6/ast.py", line 263, in generic_visit
    self.visit(value)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 36, in visit_Call
    self.capture_issues_visitor('Call', node)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 30, in capture_issues_visitor
    issues = checker.run(node)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checkers/render.py", line 22, in run
    if isinstance(arg, ast.Call) and arg.func.id == 'locals':
AttributeError: 'Attribute' object has no attribute 'id'

iLLiCiTiT added 2 commits

May 21, 2020 19:07


slate is scaled all the time to same resolution as review has

f5e66c8


fixed variable in extract review rescaling

e5477dd

hound bot reviewed

View reviewed changes

hound bot left a comment

Some files could not be reviewed due to errors:

Traceback (most recent call last):

Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 11, in 
    sys.exit(main())
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/cli.py", line 18, in main
    app.run(argv)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 393, in run
    self._run(argv)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 381, in _run
    self.run_checks()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 300, in run_checks
    self.file_checker_manager.run()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 331, in run
    self.run_serial()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 315, in run_serial
    checker.run_checks()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 598, in run_checks
    self.run_ast_checks()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 502, in run_ast_checks
    for (line_number, offset, text, check) in runner:
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 56, in run
    parser.visit(self.tree)
  File "/usr/lib/python3.6/ast.py", line 253, in visit
    return visitor(node)
  File "/usr/lib/python3.6/ast.py", line 261, in generic_visit
    self.visit(item)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 39, in visit_ClassDef
    self.capture_issues_visitor('ClassDef', node)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 33, in capture_issues_visitor
    self.generic_visit(node)
  File "/usr/lib/python3.6/ast.py", line 263, in generic_visit
    self.visit(value)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 36, in visit_Call
    self.capture_issues_visitor('Call', node)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 30, in capture_issues_visitor
    issues = checker.run(node)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checkers/render.py", line 22, in run
    if isinstance(arg, ast.Call) and arg.func.id == 'locals':
AttributeError: 'Attribute' object has no attribute 'id'


extract review slate should be backwards compatible

b925090

hound bot reviewed

View reviewed changes

hound bot left a comment

Some files could not be reviewed due to errors:

Traceback (most recent call last):

Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 11, in 
    sys.exit(main())
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/cli.py", line 18, in main
    app.run(argv)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 393, in run
    self._run(argv)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 381, in _run
    self.run_checks()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 300, in run_checks
    self.file_checker_manager.run()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 331, in run
    self.run_serial()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 315, in run_serial
    checker.run_checks()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 598, in run_checks
    self.run_ast_checks()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 502, in run_ast_checks
    for (line_number, offset, text, check) in runner:
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 56, in run
    parser.visit(self.tree)
  File "/usr/lib/python3.6/ast.py", line 253, in visit
    return visitor(node)
  File "/usr/lib/python3.6/ast.py", line 261, in generic_visit
    self.visit(item)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 39, in visit_ClassDef
    self.capture_issues_visitor('ClassDef', node)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 33, in capture_issues_visitor
    self.generic_visit(node)
  File "/usr/lib/python3.6/ast.py", line 263, in generic_visit
    self.visit(value)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 36, in visit_Call
    self.capture_issues_visitor('Call', node)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 30, in capture_issues_visitor
    issues = checker.run(node)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checkers/render.py", line 22, in run
    if isinstance(arg, ast.Call) and arg.func.id == 'locals':
AttributeError: 'Attribute' object has no attribute 'id'

jakubjezek001 approved these changes

View reviewed changes

Member

jakubjezek001 left a comment

Slate frame workflow was fixed

pype/plugins/global/publish/extract_review_slate.py Outdated

- if resolution_ratio_test < delivery_ratio_test:
- scale_factor = float(to_width) / (
- resolution_width * pixel_aspect)
+ # QUESTION Should we use resolution from instance and not source's?

Member

jakubjezek001 May 21, 2020

good question, I believe we have to check the source resolution. Perhpas the problem with mixed resolutions is coming from here


fixed index access of iterable object

6e27c92

hound bot reviewed

View reviewed changes

hound bot left a comment

Some files could not be reviewed due to errors:

Traceback (most recent call last):

Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 11, in 
    sys.exit(main())
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/cli.py", line 18, in main
    app.run(argv)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 393, in run
    self._run(argv)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 381, in _run
    self.run_checks()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 300, in run_checks
    self.file_checker_manager.run()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 331, in run
    self.run_serial()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 315, in run_serial
    checker.run_checks()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 598, in run_checks
    self.run_ast_checks()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 502, in run_ast_checks
    for (line_number, offset, text, check) in runner:
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 56, in run
    parser.visit(self.tree)
  File "/usr/lib/python3.6/ast.py", line 253, in visit
    return visitor(node)
  File "/usr/lib/python3.6/ast.py", line 261, in generic_visit
    self.visit(item)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 39, in visit_ClassDef
    self.capture_issues_visitor('ClassDef', node)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 33, in capture_issues_visitor
    self.generic_visit(node)
  File "/usr/lib/python3.6/ast.py", line 263, in generic_visit
    self.visit(value)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 36, in visit_Call
    self.capture_issues_visitor('Call', node)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 30, in capture_issues_visitor
    issues = checker.run(node)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checkers/render.py", line 22, in run
    if isinstance(arg, ast.Call) and arg.func.id == 'locals':
AttributeError: 'Attribute' object has no attribute 'id'


don't use host name from pyblish's registered_host but from AVALON_AP…

70b1cd0

…P environemnt

hound bot reviewed

View reviewed changes

hound bot left a comment

Some files could not be reviewed due to errors:

Traceback (most recent call last):

Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 11, in 
    sys.exit(main())
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/cli.py", line 18, in main
    app.run(argv)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 393, in run
    self._run(argv)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 381, in _run
    self.run_checks()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 300, in run_checks
    self.file_checker_manager.run()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 331, in run
    self.run_serial()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 315, in run_serial
    checker.run_checks()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 598, in run_checks
    self.run_ast_checks()
  File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 502, in run_ast_checks
    for (line_number, offset, text, check) in runner:
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 56, in run
    parser.visit(self.tree)
  File "/usr/lib/python3.6/ast.py", line 253, in visit
    return visitor(node)
  File "/usr/lib/python3.6/ast.py", line 261, in generic_visit
    self.visit(item)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 39, in visit_ClassDef
    self.capture_issues_visitor('ClassDef', node)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 33, in capture_issues_visitor
    self.generic_visit(node)
  File "/usr/lib/python3.6/ast.py", line 263, in generic_visit
    self.visit(value)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 36, in visit_Call
    self.capture_issues_visitor('Call', node)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 30, in capture_issues_visitor
    issues = checker.run(node)
  File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checkers/render.py", line 22, in run
    if isinstance(arg, ast.Call) and arg.func.id == 'locals':
AttributeError: 'Attribute' object has no attribute 'id'

mkolar merged commit 6afe91e into develop

mkolar added this to the 2.9 milestone

mkolar deleted the feature/PYPE-754_review_burnin_filtering branch

May 25, 2020 10:00

iLLiCiTiT mentioned this pull request

burnins presets hosts related #48

Closed

BenSouchet pushed a commit to quadproduction/OpenPype that referenced this pull request


(ynput#103) enhancement: fix doctring of get_deadline_data

4878bd3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

type: enhancement